You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cover hot reload and a watcher-disabled config in the effective-payout tests #656
#630's third acceptance criterion is still open after PR #648 fixed the first two: the effective-payout tests do not compare pool identity, account for XMRig's hot reload of the generated config, or cover a configuration with the watcher disabled. Stock XMRig watches the config file RigForge generates (systemd/xmrig.service.template), so a pool change can take effect without the restart these tests assume.
What it impacts
Test coverage of payout changes: a regression in how a new payout reaches a running miner (reload versus restart, watcher on or off) would not be caught.
How I found it
Split from #630 on 2026-11-07 by the owner's ruling for RigForge 1.18.1: #630 closes for criteria 1 and 2 (PR #648, merged as b82758b), and this criterion moves to the next release. The worker's note on #630 (2026-11-06) records that the watcher-disabled configuration exists only once watch: false generation lands in #529 / PR #608.
How important is it
Minor: test coverage for behaviour the 1.18.1 fix already corrects. It cannot be done before #529.
Acceptance criteria
The effective-payout tests compare the pool identity the miner actually uses, not only the generated file.
Activity