Repository navigation
Fix gen-proto.sh paths for the src/ layout - #48
Merged
Merged
Conversation
The proto and generated code moved under src/, but gen-proto.sh still pointed at oxia/internal/proto, so running it from the repo root as documented in CONTRIBUTING.md failed with "Could not make proto path relative". Use -Isrc and the src/ paths. The proto path relative to the include root is unchanged, so the generated "# sources:" header stays the same. Signed-off-by: Matteo Merli <mmerli@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The proto and the generated code moved under
src/, butgen-proto.shstill uses the old paths. Running./gen-proto.shfrom the repo root, as CONTRIBUTING.md says, fails. This affects anyone regenerating the protobuf bindings.Example
The current script:
Change
The script now uses
srcas the include root and points at thesrc/paths:The proto's path relative to the include root is still
oxia/internal/proto/client.proto. So the generated# sources:header and the package layout don't change.source .venv/bin/activatestays: it does nothing underuv run, but it lets the plain./gen-proto.shwork afteruv sync.Testing
I ran the script from the repo root, both with
uv run --frozenand directly. The regenerated output matches the committed stubs except for the two intentionally hand-edited streaming methods (get_sequence_updates,get_notifications), which return the cancellable call. I restored those after the run.