Repository navigation
fix(CI-05A): separate oracle setup from worker timings - #755
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh reference cache would charge oracle generation only to the serial sample in the worker benchmark. Validate/warm the oracle once before all timed browser samples and record reference_setup separately, so each pool size measures equivalent browser work.
Validation: initially empty cache, complete 39-case class corpus at 1/2/4/8 real Chromium workers, identical ordered results/resource observations and a successful JSON report. All 39 oracle cases passed; the 1.030s cold setup is recorded separately. No runtime, CI matrix or deadline changes.
#753 is merged. Closes #754.
Verification: all 16 regression jobs pass in CI run 41425599611. The affected 39-case, four-pool real-browser benchmark passes again after parent reconciliation; its oracle setup is recorded separately and the focused two-file change is retained.
Integrated-main verification:
eeb0348ebdc7fff24f6261a8face882cc8703538; main wheel/installed-CLI/source-startup smoke passes. Both local source-profile startup checks pass, and main is clean and synchronized. All five batch tasks are complete; no release or deployment accompanies these CI changes.