Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 21 focused, meaningful Vitest unit tests covering two previously untested modules in the codebase:
src/allowlist/index.ts(Query Allowlist security feature)plugins/sql-macros/index.ts(SQL Macros plugin)Closes #71
/claim #71
Test Coverage Details
1.
src/allowlist/index.test.ts(8 tests)truereturn whenisEnabledis false without calling database.config.role === "admin".Error("No SQL provided for allowlist check")when input SQL is empty.loadAllowlistdatabase failure and rejection fallback.normalizeSQL).tmp_allowlist_rejectionsviaaddRejectedQuery.addRejectedQuerydatabase insertion failure.2.
plugins/sql-macros/index.test.ts(13 tests)starbasedb:sql-macrosand options setup.preventSelectStar:SELECT *for non-admin users with specific error message.config.role === "admin".$_excludeColumn Macro:pragma_table_infoqueries.$_excludewith remaining table schema columns for single excluded column.$_excludefor multiple excluded columns.$_exclude.Verification
pnpm test src/allowlist/index.test.ts plugins/sql-macros/index.test.ts: 21 / 21 tests passed (100%).pnpm exec prettier --check.