Skip to content

Improve test coverage with Vitest #71

Open
Open

Description

@Brayden

Is your feature request related to a problem? Please describe.
Currently the test coverage of the project is nearly non-existent. We do have and use Vitest as a dependency in the Starbase project already that future tests should also use. The idea is to begin accumulating test coverage throughout the entire project.

Goal is to bring test coverage up to above 75% with meaningful tests.

Describe the solution you'd like
Important: Tests should not just be made for line coverage, they should also include meaningful tests that help reveal when issues arise. For example, if we were to write a test for our LiteREST code to see if making a request fetched data we would pass it potentially:

  • a real table name
  • a fake table name
  • no table name (omitted altogether)
  • -1 or null as a value

When PR's are made we run the following Github test action (https://github.com/outerbase/starbasedb/blob/main/.github/workflows/test.yaml) that verifies the project can execute a pnpm i and then run tests with pnpm test. All tests added should be executed during that same pnpm test command.

Describe alternatives you've considered
N/A

Additional context
N/A

Activity

  1. Brayden commented on Jan 24, 2025

    @Brayden
    MemberAuthor

    /bounty $250

  2. algora-pbc commented on Jan 24, 2025

    @algora-pbc

    💎 $250 bounty • Outerbase (YC W23)

    Steps to solve:

    1. Start working: Comment /attempt #71 with your implementation plan
    2. Submit work: Create a pull request including /claim #71 in the PR body to claim the bounty
    3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

    ❗ Important guidelines:

    • To claim a bounty, you need to provide a short demo video of your changes in your pull request
    • If anything is unclear, ask for clarification before starting as this will help avoid potential rework
    • Low quality AI PRs will not receive review and will be closed
    • Do not ask to be assigned unless you've contributed before

    Thank you for contributing to outerbase/starbasedb!

    Attempt Started (UTC) Solution Actions
    🟢 @AlonePenguin Jun 01, 2026, 01:07:27 PM #263 Reward
    🟢 @Rafly0078 Jun 03, 2026, 03:26:57 PM #268 Reward
    🟢 @TechEnthusGH Jun 03, 2026, 06:06:14 PM #269 Reward
    🟢 @tunguz May 11, 2026, 10:11:28 PM #149 Reward
    🟢 @INDICUMA May 11, 2026, 11:47:29 PM #150 Reward
    🟢 @Mykidzou May 12, 2026, 05:44:09 AM #151 Reward
    🟢 @Iineman2 May 12, 2026, 06:54:13 AM #153 Reward
    🟢 @joshpi-1345 May 12, 2026, 07:13:11 AM #156 Reward
    🟢 @Gimyoonsoo May 12, 2026, 07:09:44 AM #155 Reward
    🟢 @ScryUser May 12, 2026, 07:41:20 AM #159 Reward
    🟢 @hieunt170746 May 12, 2026, 07:45:19 AM #157 Reward
    🟢 @kanjk0olb0y-a11y May 12, 2026, 07:09:07 AM #154 Reward
    🟢 @kaziiza May 12, 2026, 09:52:18 AM #163 Reward
    🟢 @kingzzoov-ctrl May 12, 2026, 09:19:20 AM #162 Reward
    🟢 @akamabu May 12, 2026, 09:13:13 AM #161 Reward
    🟢 @obmakesomething May 12, 2026, 10:09:53 AM #164 Reward
    🟢 @thedalbee May 12, 2026, 02:46:57 PM #165 Reward
    🟢 @shengtenghou4-star May 12, 2026, 02:55:17 PM #166 Reward
    🟢 @xingxi0614-cpu May 12, 2026, 04:25:06 PM #169 Reward
    🟢 @mt211211 May 12, 2026, 06:58:24 PM #170 Reward
    🟢 @KaannKara May 12, 2026, 07:23:16 PM #171 Reward
    🟢 @Treasure520520 May 12, 2026, 07:57:13 PM #176 Reward
    🟢 @popsiclelmlm May 12, 2026, 08:35:40 PM #185 Reward
    🟢 @newmattock May 12, 2026, 08:23:40 PM #182 Reward
    🟢 @treydoe1 May 12, 2026, 09:18:48 PM #186 Reward
    🟢 @TheWaste11202 May 12, 2026, 10:48:04 PM #187 Reward
    🟢 @jorgeschulz May 12, 2026, 10:33:47 PM #189 Reward
    🟢 @lisiqi1983 May 13, 2026, 02:45:22 AM #199 Reward
    🟢 @JetMatrix May 13, 2026, 02:13:31 AM #197 Reward
    🟢 @benbenlijie May 13, 2026, 03:25:39 AM #200 Reward
    🟢 @taherdhanera May 13, 2026, 09:13:41 AM #204 Reward
    🟢 @richboyneedcash May 13, 2026, 03:30:05 PM #207 Reward
    🟢 @imaanmulji May 13, 2026, 05:53:26 PM #209 Reward
    🟢 @himanalot May 13, 2026, 06:19:32 PM #210 Reward
    🟢 @duct-tape2 May 14, 2026, 09:15:59 AM #211 Reward
    🟢 @sureshchouksey8 May 14, 2026, 10:55:02 AM #214 Reward
    🟢 @RupteRyuxh May 14, 2026, 08:37:31 PM WIP
    🟢 @singhaditya21 Jun 15, 2026, 05:57:30 AM #277 Reward
    🟢 @oocheol May 18, 2026, 04:10:28 AM #226 Reward
    🟢 @manuelsampedro1 May 18, 2026, 10:18:32 PM #227 Reward
    🟢 @mkcash May 19, 2026, 09:20:28 AM WIP
    🟢 @Qian001A May 22, 2026, 11:47:30 AM #242 Reward
    🟢 @gebibd00-jpg May 22, 2026, 11:03:09 AM #241 Reward
    🟢 @Myc911 Apr 23, 2026, 02:48:29 AM WIP
    🟢 @dominyyin-sudo May 23, 2026, 05:50:38 AM #247 Reward
    🟢 @pofuhermes-bit Apr 23, 2026, 06:45:21 AM WIP
    🟢 @varshith257 Jan 24, 2025, 04:26:08 PM #74 Reward
    🟢 @aybanda Jan 24, 2025, 06:00:30 PM WIP
    🟢 @adliebe May 27, 2026, 09:11:55 AM #252 Reward
    🟢 @jasperan May 27, 2026, 11:39:15 AM #253 Reward
    🟢 @kpassito May 27, 2026, 06:37:55 PM #254 Reward
    🟢 @Entr0zy May 30, 2026, 11:45:23 AM #257 Reward
    🟢 @kodedihp May 30, 2026, 01:00:31 PM WIP
    🟢 @attaboy11 May 30, 2026, 10:36:10 PM #261 Reward
  3. varshith257 commented on Jan 24, 2025

    @varshith257
    Contributor

    /attempt #71

    Algora profile Completed bounties Tech Active attempts Options
    @varshith257 25 bounties from 11 projects
    Scala, Rust,
    TypeScript & more
    Cancel attempt
  4. aybanda commented on Jan 24, 2025

    @aybanda

    /attempt #71

    Algora profile Completed bounties Tech Active attempts Options
    @aybanda 2 bounties from 2 projects
    TypeScript, Python,
    Julia & more
    Cancel attempt
  5. varshith257 commented on Jan 24, 2025

    @varshith257
    Contributor

    @Brayden There are a few bugs in implementations that are getting found during tests. I am fixing them too along with the testing. Could I draft PR?

  6. Brayden commented on Jan 24, 2025

    @Brayden
    MemberAuthor

    @Brayden There are a few bugs in implementations that are getting found during tests. I am fixing them too along with the testing. Could I draft PR?

    You may absolutely fix issues along the way. Feel free to draft a PR @varshith257!

  7. varshith257 commented on Jan 24, 2025

    @varshith257
    Contributor

    @Brayden I have opened

    and fixing few more implementations caught in the way in testing

  8. algora-pbc commented on Jan 24, 2025

    @algora-pbc

    💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

  9. algora-pbc commented on Feb 17, 2025

    @algora-pbc

    🎉🎈 @varshith257 has been awarded $250! 🎈🎊

  10. Myc911 commented on Apr 23, 2026

    @Myc911

    /attempt #71

  11. pofuhermes-bit commented on Apr 23, 2026

    @pofuhermes-bit

    /attempt #71

    Implementation plan:

    1. Reproduce current Vitest + coverage baseline on main
    2. Fix the RLS regression causing failing coverage tests
    3. Add meaningful tests for uncovered branches/modules (starting with allowlist and worker entry flow)
    4. Re-run pnpm test -- --coverage and only submit if thresholds pass

    I'll include /claim #71 in the PR body and a short demo video if I get this green.

  12. 99 remaining items

  13. sonofkratos92 commented on Oct 27, 2026

    @sonofkratos92

    /attempt #71

  14. Yuvi1192p commented on Oct 29, 2026

    @Yuvi1192p

    /attempt #71

    Submitted in PR #309 (opened Oct 24):

    • Coverage Exceeded: Brought overall test coverage across the repository to 87.47% Lines and 77.21% Branches (well exceeding the >= 75% requirement).
    • Comprehensive Test Suite: 216 tests passing across 22 test files with 0 failures.
    • Bug Fixes: Resolved schema-qualified policy table matching and nested subquery AST traversal.

    All acceptance criteria complete in PR #309, ready for maintainer review!

  15. added a commit that references this issue on Nov 4, 2026
    4da0a7e
  16. GabrielHFGoncalez commented on Nov 4, 2026

    @GabrielHFGoncalez

    /attempt #71

    Submitted focused, non-overlapping Vitest coverage for plugins/resend/index.ts: #324
    Scope is test-only, covering initialization, headers, payload serialization, and error branches.

  17. GabrielHFGoncalez commented on Nov 4, 2026

    @GabrielHFGoncalez

    /attempt #71

    Submitted comprehensive Vitest test coverage for the Resend plugin (plugins/resend/index.test.ts):
    PR: #324

    • Tests initialization and API key validation.
    • Tests successful email delivery via mock fetch with exact header and JSON payload assertions.
    • Tests error handling paths (non-ok responses and fallback error messages).
    • 100% test-only slice with zero modifications to runtime logic. Ready for review!
  18. added 5 commits that reference this issue on Nov 4, 2026
    edcb246
    310b726
    ce0c5ec
    d621aa7
    3ac7c3c
  19. satoshinakamoto666666 commented on Nov 11, 2026

    @satoshinakamoto666666

    /claim #71

    Submitted complete, unit-tested implementation in PR: #341

    Implementation & Verification Summary

    Payout Wallets

    • EVM (ERC-20 / Base / Arbitrum / Polygon / Optimism / Gnosis): 0x971b573b47357c22a67FcE8c56Aaeb478356C942
    • Solana (SOL / USDC): Aw2hhJvjewAcxssyWMzKmFge6jWxEzN6GiFQgyZNKakt
    • Stellar (XLM / USDC): GCJZA6CW23ABZSJIPSDCDHWAKDC35BQCSKDDMTIAKTCCZ6K3HV7TLOTD
    • RustChain Mainnet RTC: RTCfe0ac752b80e543048c0d91e7dddd1277678b8a5 (bcn_fe0ac752b80e)
    • Tari Mainnet XTM: 14KXqz6bKtJLq61guEFup3BWMarTDaxwwWBEcsYGtaFwXcvpLu5iJzBxnH88Mn8QSnvkEJZ2NcWy4Lw3ZcUtr4hvbkG
  20. khuxaiphi-stack commented on Nov 14, 2026

    @khuxaiphi-stack

    /attempt #71

    Submitted PR #347 with 100% deterministic unit test suites across all 5 modules (18 / 18 tests passing in Vitest).

  21. Gubaarev commented on Nov 15, 2026

    @Gubaarev

    /attempt #71

    Implementation plan:

    • Add comprehensive Vitest unit test suite for Query Allowlist (src/allowlist/index.ts):
      • Test feature toggle bypass (isEnabled: false) and administrative bypass (config.role === "admin").
      • Test validation edge cases (missing SQL input, loadAllowlist database failure).
      • Test AST normalization and query comparison (exact match, structural AST match).
      • Test rejected query logging into tmp_allowlist_rejections and rejection insertion error resilience.
    • Add comprehensive Vitest unit test suite for SQL Macros (plugins/sql-macros/index.ts):
      • Test middleware registration and config capturing.
      • Test SELECT * prevention for non-admin users, admin bypass, explicit column allowance, non-SELECT statement handling, and syntax error resilience.
      • Test $_exclude column macro replacement with single and multiple excluded columns, non-internal data source bypass, pragma query bypass, and normal queries.
    • Zero production code changes. All 21 new tests pass with Vitest and comply with Prettier style checks.
  22. AgoniJJ commented on Nov 15, 2026

    @AgoniJJ

    Opened #352 with the first batch: 8 tests for src/allowlist (previously untested) plus a one-line fix for a truthy-Error allowlist bypass on empty SQL. CI: 8/8 pass; the only suite failures are pre-existing RLS tests on main. Happy to keep adding coverage module by module.

  23. Hidayat666-ali commented on Nov 15, 2026

    @Hidayat666-ali

    /attempt #71

    Implementation Plan: Improve Vitest Test Coverage

    Submitting full, comprehensive Vitest test coverage for previously untested modules (#71):

    1. Query Allowlist (src/allowlist/index.test.ts):
      • Tests feature disabled state (isEnabled: false) and administrative bypass (config.role: 'admin').
      • Tests exact AST query comparison, whitespace normalization, and trailing semicolon tolerance.
      • Tests unauthorized query rejection and audit logging into mp_allowlist_rejections.
      • Fixes truthy-Error allowlist bypass on empty SQL in src/allowlist/index.ts so it throws consistently.
    2. Resend Email Plugin (plugins/resend/index.test.ts):
      • Tests plugin initialization, �piKey handling, and authorization header generation.
      • Tests sendEmail() successful execution and JSON payload formatting.
      • Tests non-ok response handling and fallback error messages.
    3. SQL Macros Plugin (plugins/sql-macros/index.test.ts):
      • Tests preventSelectStar enforcement for non-admin users and admin bypass.
      • Tests $_exclude column macro replacement against internal SQLite schema pragmas.
      • Tests non-internal data source bypass and pragma query tolerance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions