You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ports only the prototype's iOS Balances home: SwiftUI list, totals, large title and native search. Adds native Liquid Glass header buttons, long-press balance previews (View balance, Add expense, Settle up), light action haptics, Dynamic Type layout and VoiceOver labels. No swipe actions.
Rows use SDK 58 List.ForEach recycling, stable friend keys, a memoized renderer/row and memoized search results. Avatar state resets when the recycled friend/image changes. Add expense, split editor, layouts, mutations, Android Balances and EAS configuration stay as on main; no guards or dependencies added.
Verified locally on iPhone 18 Pro with 200 fictional friends. Only 13 home avatars initially mounted, 28 after scrolling. Development React profiling: scrolling 56ms over 23 commits (max 23ms); typing 208ms over 24 commits (max 62ms on broad result changes, later updates 1.5–6.1ms). No sustained stalls observed; native FPS sampling is unavailable on the simulator. Typecheck, lint, formatting and all 65 tests pass. Earlier real save/refresh checks, iOS build and Android export also passed; physical haptics and spoken VoiceOver need device testing.
Refreshed screenshots in ~/git/personal/notes/splitpro/native-home/: top-light.png shows the native header and full-width rows; context-dark.png shows the retained balance preview and three actions. Also retook collapsed titles, search and larger text; deleted swipe screenshots. Detailed observations are in verification.md.
Summary by CodeRabbit
New Features
Added an iOS-native balances screen with friend search, balance totals, and quick actions for adding expenses and settling up.
Search matches friend names and email addresses, ignoring capitalization and surrounding whitespace.
Added clear loading, error, empty, and no-results states, with a retry option when loading fails.
No actionable comments were generated in the recent review.
Walkthrough
The balances screen now uses an iOS-native view with search, totals, friend actions, and loading or empty states. Other platforms keep the existing list. The new search helper matches friend names and email addresses.
The new helper filters by friend name or email after trimming and lowercasing the query. Tests cover whitespace, missing profile fields, matches, and empty results.
The iOS view displays balance totals and friend rows with navigation, add-expense, and settle-up actions. It handles loading, errors, no results, and empty data. English locale strings support search and empty states.
The balances route passes balance data, search, loading, error, and refresh state to the iOS view. Other platforms retain the existing list and add-expense action.
sequenceDiagram
actor User
participant Balances
participant NativeBalances
User->>Balances: Enter a search query
Balances->>NativeBalances: Pass search and balance state
NativeBalances->>NativeBalances: Filter balances and render results
User->>NativeBalances: Request refresh after an error
NativeBalances->>Balances: Invoke onRefresh
Balances->>Balances: Await refetch
Loading
Possibly related PRs
oss-apps/split-pro-cloud#38: Adds bearer-session authentication to the mobile tRPC context used to authorize the balances query.
Merge Risk: Minimal · previous review 273e6
The change adds an iOS-native Balances screen and leaves other platforms on the existing list. No actionable merge-blocking risk remains. Physical haptics and VoiceOver still need device testing, as the author notes.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the main change: a native iOS Balances home screen.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 5 files. (1 skipped: 1 unsupported.)
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports only the prototype's iOS Balances home: SwiftUI list, totals, large title and native search. Adds native Liquid Glass header buttons, long-press balance previews (View balance, Add expense, Settle up), light action haptics, Dynamic Type layout and VoiceOver labels. No swipe actions.
Rows use SDK 58 List.ForEach recycling, stable friend keys, a memoized renderer/row and memoized search results. Avatar state resets when the recycled friend/image changes. Add expense, split editor, layouts, mutations, Android Balances and EAS configuration stay as on main; no guards or dependencies added.
Verified locally on iPhone 18 Pro with 200 fictional friends. Only 13 home avatars initially mounted, 28 after scrolling. Development React profiling: scrolling 56ms over 23 commits (max 23ms); typing 208ms over 24 commits (max 62ms on broad result changes, later updates 1.5–6.1ms). No sustained stalls observed; native FPS sampling is unavailable on the simulator. Typecheck, lint, formatting and all 65 tests pass. Earlier real save/refresh checks, iOS build and Android export also passed; physical haptics and spoken VoiceOver need device testing.
Refreshed screenshots in ~/git/personal/notes/splitpro/native-home/: top-light.png shows the native header and full-width rows; context-dark.png shows the retained balance preview and three actions. Also retook collapsed titles, search and larger text; deleted swipe screenshots. Detailed observations are in verification.md.
Summary by CodeRabbit