Repository navigation
Release v0.3.0: fail release on upload errors, correct action pin comments - #3
Merged
Merged
Conversation
…n comments
- Bump the workspace version from 0.1.0 to 0.3.0 (Cargo.toml, Cargo.lock,
README). v0.2.x binaries still reported 0.1.0; main now carries custom post
type routing, content files, media upload and `wpx api`.
- release.yml: drop `|| true` from `gh release upload` so a failed upload
fails the build job instead of silently shipping a release without assets.
- release.yml: build now `needs: create-release`. The two jobs ran in
parallel and `|| true` hid the race; without it an upload that beat the
release creation would fail.
- ci.yml / release.yml: the version comments on the pinned SHAs did not
match what the SHAs are. Verified each against upstream:
- actions/checkout 34e11487 is tag v4.3.1 (the v4 tag has since moved).
- dtolnay/rust-toolchain 3c5f7ea2 is a master commit (27 Mar 2026), not
the `stable` branch, which is why it has no default `toolchain` input
and why CI failed until `toolchain: stable` was added.
- Swatinem/rust-cache e18b4977 is v2.9.1 plus one CHANGELOG-only commit
on master.
SHAs are unchanged; only the comments are corrected.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the v0.3.0 release from current
mainand closes out the CI/release workflow follow-ups from the SHA pinning.Version bump to 0.3.0 (workspace
Cargo.toml,Cargo.lock, README). The v0.2.x tags were cut while the workspace still said0.1.0, sowpx --versionreported 0.1.0.mainnow has custom post type routing (--type blog), content files, media upload andwpx api, so this is a minor bump.release.yml: a failed asset upload now fails the job. Removed
|| truefromgh release upload.release.yml:
buildnowneeds: create-release. The two jobs ran in parallel and|| truehid the race. Without it, an upload that beat the release creation would fail the job.Pin comments corrected, SHAs unchanged. I checked each pinned
uses:against upstream:34e11487…v4v4.3.1(thev4tag has since moved to v4.4.0)3c5f7ea2…stablemastercommit (27 Mar 2026), not thestablebranch, so it has no defaulttoolchaininpute18b4977…v2v2.9.1plus one CHANGELOG-only commit onmasterThe two failed CI runs
dtolnay/rust-toolchainstep. The logs have expired (HTTP 410), but the annotations point to the toolchain-parse line. The same cause is visible in the next run.'toolchain' is a required input: the pinned SHA is amastercommit, which has no default toolchain.toolchain: stableexplicitly in ci.yml and release.yml, and the 9 Oct runs on main are green. The comment fix here stops anyone removing that input later because they think it is redundant.Local checks
cargo check,cargo test --workspace(all pass),cargo clippy --workspace -- -D warnings,cargo fmt --all -- --check,wpx man --dirandactionlintare all clean.🤖 Generated with Claude Code