Repository navigation
Conversation
Member
|
Thanks for looking into this and trying Ninja. Looks like it fails too though: https://github.com/clarisma/pyosmium/actions/runs/38400294853/job/115305879836 |
Contributor
Author
|
I've changed it to use a fixed directory. Testing now |
Contributor
Author
|
Giving each build an explicit dir seems to fix it. |
Contributor
Author
|
Looks like it worked! |
lonvia
reviewed
Oct 13, 2026
Member
|
I've merged this now outside Github. I've left out the change for ninja as this was acting up and in the end I prefer trusting the defaults of scikit-build. Thanks again for getting to the bottom of this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses Ninja as the build system (The default builder has a telemetry process that keeps the build directory locked, which causes an error during cleanup).
Also fixes msvc setup on arm and gets the correct package for lz4 (x64 instead of x86).
Heads up: I can't test this locally, so no guarantees this will work.