Repository navigation
Conversation
Member
|
Thanks for finding the issue and proposing a fix. The Python code in a string in the test is a bit unusual and hard to read. I played around with the multiprocessing module and came up with a version in #326 that is closer to a simple function call. Closing here in favour of the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception during Python OSM wrapper construction leaves
m_validtrue whilem_pyobjis still null. The destructor then dereferences that null object while invalidating_pyosmium_data, turning a Python exception into a native crash.Set
m_validonly after construction and assignment succeed. Add a subprocess regression covering Node, Way and Relation constructors interrupted by KeyboardInterrupt, MemoryError and RuntimeError, including cleanup after the exception is caught.Fixes #323.
Validation on CPython 3.14.8 / macOS ARM64:
test_object_construction.pyplus this checkout'stest_file_processor.py: 24 passed against that patched native build.The native validation build is the 4.3.1 release with this header change, rather than a fresh build of all other current-master source. No signal handlers are suppressed or replaced by the fix.