Repository navigation
Add a basic editor config file - #322
Closed
amandasaurus wants to merge 1 commit into
Closed
amandasaurus wants to merge 1 commit into
amandasaurus wants to merge 1 commit into
Conversation
Member
|
I'm sorry but I will reject this. The coding conventions such a config file can capture are so minimal that it is not really worth maintaining an extra file for this. The linting check in the CI will catch all grave deviations from the expected standard well enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditorConfig is a file you can put in a project to define white space, tabs-vs-spaces etc. Lots of software editors support it. There is currently none for this project. The CI checks test for mixing tabs & spaces, and I accidentally included a tab. With this PR, new developers are less likely to make mistakes.