[tmshort]

Summary

• Run controller-gen with go tool at the controller-tools v0.23.0 version already required by go.mod.
• Remove the separate Bingo controller-gen v0.21.0 pin.
• Regenerate apply configurations with v0.23.0.

Generated output

The four top-level apply configuration types now use json:"" for embedded TypeMeta, as emitted by v0.23.0. CRD schemas and release manifests are unchanged.

Verification

• make generate manifests
• go test ./api/v1/... ./applyconfigurations/... with the installed envtest binaries
• make verify

Summary by CodeRabbit

• Bug Fixes

  • Updated metadata serialization in generated apply configurations for cluster resources.

• Chores

  • Updated code-generation tooling management and refreshed generated files to match. Other managed tools remain unchanged.

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	4f01c0f
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/6ae373be4e00e74043780869
😎 Deploy Preview	https://deploy-preview-3082--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Enterprise
• Run ID: 29452252-f021-4ef5-b0eb-1604cf08b006

Commits

Reviewing files that changed from the base of the PR and between 255a402 and 4f01c0f.

Files ignored due to path filters: 2

• .bingo/controller-gen.sum is excluded by !**/*.sum
• go.sum is excluded by !**/*.sum

Files selected for processing: 10

• .bingo/Variables.mk
• .bingo/controller-gen.mod
• .bingo/variables.env
• AGENTS.md
• Makefile
• applyconfigurations/api/v1/clustercatalog.go
• applyconfigurations/api/v1/clusterextension.go
• applyconfigurations/api/v1/clusterobjectdeployment.go
• applyconfigurations/api/v1/clusterobjectset.go
• go.mod

Files with no reviewable changes: 3

• .bingo/Variables.mk
• .bingo/variables.env
• .bingo/controller-gen.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

Walkthrough

The repository replaces its .bingo-managed controller-gen binary with the Go tool directive in go.mod. The Makefile invokes go tool controller-gen. Four generated apply configuration files have updated controller-gen headers and TypeMetaApplyConfiguration JSON tags.

Changes: Controller-gen tool migration

Layer / File(s)	Summary
Manage controller-gen through Go tooling go.mod, Makefile, .bingo/Variables.mk, .bingo/controller-gen.mod, .bingo/variables.env, AGENTS.md	go.mod declares controller-gen as a tool, and the Makefile invokes it with go tool. The previous .bingo binary configuration is removed. AGENTS.md identifies the Go tool directive as its manager.
Update generated apply configurations applyconfigurations/api/v1/clustercatalog.go, applyconfigurations/api/v1/clusterextension.go, applyconfigurations/api/v1/clusterobjectdeployment.go, applyconfigurations/api/v1/clusterobjectset.go	The generated headers omit the controller-gen version suffix. Each TypeMetaApplyConfiguration JSON tag changes from json:",inline" to json:"".

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

• operator-framework/operator-controller#3075: Updates the controller-tools version in go.mod, sharing the Go-tool-managed controller-gen version contract.
• operator-framework/operator-controller#2977: Updates the controller-tools version in go.mod and generated CRD annotations as part of the controller-gen version migration.

Suggested reviewers: joelanford, grokspawn, fgiudici

Merge Risk: Minimal · up to 4f01c

The controller-gen migration is ready to merge with no identified merge-blocking risk.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the main change: running controller-gen v0.23.0 from go.mod. It uses the required seedling prefix and is concise.
Description check		The description explains the change, motivation, generated output, and verification steps. It does not include the reviewer checklist, but the required change and validation details are complete.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 4 files. (3 skipped: 3 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[grokspawn]

It's worth emphasizing here that this switches the paradigm from bingo to go tool ONLY for controller-gen, so the result is a heterogeneous dependency environment. Generally, I'd prefer that we did the version change in one PR and a systematic migration to go tool in a second PR.

[tmshort]

@grokspawn

It's worth emphasizing here that this switches the paradigm from bingo to go tool ONLY for controller-gen, so the result is a heterogeneous dependency environment. Generally, I'd prefer that we did the version change in one PR and a systematic migration to go tool in a second PR.

Yes, at this time, we're switching both at the same time. Did you want two separate PRs?

[rashmigottipati]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rashmigottipati
Once this PR has been reviewed and has the lgtm label, please assign pedjak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment