Repository navigation
feat(openworkflow): pluggable logger - #879
Merged
Merged
Conversation
Add a `logger` option to `Worker` and to the `OpenWorkflow` client, which passes it to workers created with `newWorker()` unless a worker sets its own. The interface is console-compatible (`debug`, `info`, `warn`, `error`) and defaults to `console`, so output is unchanged unless a logger is provided. Worker tick, heartbeat, and critical execution errors now go through it.
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Catch errors thrown by the logger so the poll loop keeps running and heartbeat failures can't become unhandled rejections. Pass the error to pino as `err` in the docs example so its serializer applies.
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jamescmartinez
enabled auto-merge (squash)
October 12, 2026 15:48
Contributor
|
merging, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #877
Summary
Adds a console-compatible
loggeroption (debug/info/warn/error) so worker errors can go to a structured logger. Defaults toconsole, so output is unchanged unless a logger is provided.Changes
Loggertype (exported) andloggeroption onWorkerand theOpenWorkflowclient;newWorker()inherits the client's logger unless overriddenconsole.errorcalls (tick, heartbeat, critical execution error) now go through itI didn't add it to the CLI config, since the CLI has its own consola output; happy to if you'd like.