Repository navigation
fix(tIED): scope LNode deduplication to the LNode's parent container - #159
Merged
Merged
Conversation
The SCL schema applies the LNode uniqueness constraint to the LNode's immediate parent container, but detachLNodeBindings grouped unbound LNodes by the nearest Bay, VoltageLevel or Substation. A bound LNode in one ConductingEquipment could therefore be deleted because an unbound LNode with the same key existed in a sibling container under the same Bay. Use the parent element as the scope and add each LNode changed to iedName="None" to the cache, so duplicate keys among the bound LNodes handled in a single call are also detected. Closes openscd#158
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeIED(..., { preserveLNodes: true })deduplicated preserved LNodes byln.closest('Bay, VoltageLevel, Substation'), but the SCL schema applies the uniqueness constraint to the LNode's immediate parent container (e.g.ConductingEquipment,Function). An unbound LNode in one container therefore caused a bound LNode with the same key in a sibling container under the same Bay to be deleted instead of preserved asiedName="None".ln.parentElementas the deduplication scope.iedName="None"to the cache during the call, so duplicate keys among the bound LNodes handled in one call are also detected.lnInst,lnClass,ldInst,prefix) are unchanged;iedNameis not part of the key.Tests
ConductingEquipmentcontainers, one already unbound. Verifies the returned edits and the document after applying them.iedName="None"and the other is removed.Closes #158