Repository navigation
Reject failed reference uploads before registration - #682
Open
agocharbhatia wants to merge 1 commit into
Open
agocharbhatia wants to merge 1 commit into
agocharbhatia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Reject a failed reference-dataset storage upload before registering its URI with the inference pipeline. Previously,
upload_reference_dataframeignored the upload response and attempted registration even after an HTTP error.Changes
Context
The reference helper should only register a URI after the archive has uploaded successfully. This fixes that client-side ordering; it does not change the shared uploader or generated API.
Testing
Run the regressions with
python -m pytest -o addopts= tests/test_data_uploads.py. They use synthetic data and reject live network connections.Full Pyright and Mypy have unchanged diagnostics on the base and patch in my local environment. The pinned development install could not resolve
backports-asyncio-runner==1.2.0on Python 3.13, so I am not claiming a clean full type-check run. No live Openlayer or object-store tests were run.