Skip to content

fix: harden Credly OAuth client and admin, add tests - #3021

Open
GlugovGrGlib wants to merge 3 commits into
openedx:masterfrom
GlugovGrGlib:gglugovskiy/credly-oauth-followup
Open

GlugovGrGlib wants to merge 3 commits into
openedx:masterfrom
GlugovGrGlib:gglugovskiy/credly-oauth-followup

Conversation

@GlugovGrGlib

Copy link
Copy Markdown
Member

Description

Follow-up to #3002 (OAuth 2.0 Client Credentials support for Credly). This branch is stacked on top of that PR's commit and addresses the remaining review findings.

  • Regenerate migration 0003 so it matches the model (null=True was removed from the model but not from the migration).
  • Refresh the cached OAuth access token and retry once when Credly responds with 401.
  • Raise CredlyError on a non-JSON token response.
  • Carry the HTTP status code on BadgeProviderError.
  • Make CredlyOrganizationAdmin fieldsets respect pre-configured organizations (masked API key, read-only OAuth fields) instead of the now unused get_fields override.
  • Mock the Credly API call in the invalid-organization form test instead of hitting the live API.
  • Add tests for the OAuth client logic and the admin fieldsets.

Testing

pytest credentials/apps/badges passes; makemigrations --check reports no changes.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 4, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @GlugovGrGlib!

This repository is currently maintained by @jajjibhai008.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

luisfelipec95 and others added 2 commits November 4, 2026 14:52
Follow-up to openedx#3002 (OAuth 2.0 Client Credentials support for Credly).

- Regenerate migration 0003 so it matches the model (no null=True)
- Refresh the cached OAuth token and retry once when Credly returns 401
- Raise CredlyError on a non-JSON token response
- Carry the HTTP status code on BadgeProviderError
- Make admin fieldsets respect pre-configured organizations
  (masked API key, read-only OAuth fields) instead of the unused get_fields
- Mock the Credly API call in the invalid-organization form test
- Add tests for the OAuth client logic and the admin fieldsets
@GlugovGrGlib
GlugovGrGlib force-pushed the gglugovskiy/credly-oauth-followup branch from 7fbc21b to c695dbc Compare November 4, 2026 13:52
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: No status
Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants