Repository navigation
fix: harden Credly OAuth client and admin, add tests - #3021
GlugovGrGlib wants to merge 3 commits into
Conversation
|
Thanks for the pull request, @GlugovGrGlib! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Follow-up to openedx#3002 (OAuth 2.0 Client Credentials support for Credly). - Regenerate migration 0003 so it matches the model (no null=True) - Refresh the cached OAuth token and retry once when Credly returns 401 - Raise CredlyError on a non-JSON token response - Carry the HTTP status code on BadgeProviderError - Make admin fieldsets respect pre-configured organizations (masked API key, read-only OAuth fields) instead of the unused get_fields - Mock the Credly API call in the invalid-organization form test - Add tests for the OAuth client logic and the admin fieldsets
7fbc21b to
c695dbc
Compare
Description
Follow-up to #3002 (OAuth 2.0 Client Credentials support for Credly). This branch is stacked on top of that PR's commit and addresses the remaining review findings.
0003so it matches the model (null=Truewas removed from the model but not from the migration).CredlyErroron a non-JSON token response.BadgeProviderError.CredlyOrganizationAdminfieldsets respect pre-configured organizations (masked API key, read-only OAuth fields) instead of the now unusedget_fieldsoverride.Testing
pytest credentials/apps/badgespasses;makemigrations --checkreports no changes.