Repository navigation
Conversation
thaJeztah
force-pushed
the
migrate_validate
branch
from
October 12, 2026 09:03
ce09b2b to
8472982
Compare
Merged
Contributor
|
@thaJeztah please rebase, #1326 is merged now. |
thaJeztah
force-pushed
the
migrate_validate
branch
from
October 13, 2026 16:54
8472982 to
755c3f6
Compare
thaJeztah
marked this pull request as ready for review
October 13, 2026 16:54
thaJeztah
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
tianon and
utam0k
as code owners
October 13, 2026 16:54
Member
Author
|
Thx, saw it; rebased 👍 |
thaJeztah
force-pushed
the
migrate_validate
branch
from
October 13, 2026 17:19
755c3f6 to
92162b8
Compare
github.com/xeipuuv/gojsonschema is unmaintained; migrate to a maintained json-schema module. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
migrate_validate
branch
from
October 13, 2026 17:34
92162b8 to
b825013
Compare
kolyshkin
reviewed
Oct 14, 2026
| var documentLoader gojsonschema.JSONLoader | ||
| schema, err := compiler.Compile(schemaPath) | ||
| if err != nil { | ||
| fmt.Println(err) |
Contributor
There was a problem hiding this comment.
nit: fmt.Fprintln(os.Stderr, err)
kolyshkin
approved these changes
Oct 14, 2026
kolyshkin
left a comment
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
a couple of nits, overall LGTM
kolyshkin
reviewed
Oct 14, 2026
| type httpURLLoader struct{} | ||
|
|
||
| func (httpURLLoader) Load(url string) (any, error) { | ||
| resp, err := http.Get(url) |
Contributor
There was a problem hiding this comment.
nit: maybe add a timeout here? Say
client := &http.Client{Timeout: 30 * time.Second}
resp, err := client.Get(url)
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
schema/validate: migrate to santhosh-tekuri/jsonschema/v6
github.com/xeipuuv/gojsonschema is unmaintained; migrate to a
maintained json-schema module.