Skip to content

feat: offer selective voice-model removal when uninstalling Companion - #2328

Open
roboclaw-bot wants to merge 9 commits into
mainfrom
openclaw/quick-shrimp-2
Open

roboclaw-bot wants to merge 9 commits into
mainfrom
openclaw/quick-shrimp-2

Conversation

@roboclaw-bot

@roboclaw-bot roboclaw-bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What Problem This Solves

Related: #2286

Adds opt-in Kokoro cleanup with measured previews.

Draft: signed upgrade proof and four WSL E2E failures remain open.

User Impact

Default: keep models, including silent uninstall. Preview paths/bytes before consent. Other data and Gateway removal stay separate.

Why This Change Was Made

Async preview; atomic worker receipts. Deletion rechecks hashes, pinned paths and migration; no recursion.

Evidence

Real installed UI: signed baseline vs unsigned Dev. Keep, Cancel, and removal passed; settings/sentinel preserved.

Before
Before

After
After

Video (cropped, 16 seconds):
https://github.com/user-attachments/assets/06411dad-c32b-43cd-abce-90487100b8af

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Docs or instructions
  • Tests or validation
  • Security hardening
  • Chore or infrastructure

Scope

  • Tray or WinUI UX
  • Windows node capability
  • Local MCP or winnode
  • Gateway, connection, or pairing
  • Setup or onboarding
  • Permissions, privacy, or security
  • Tests, CI, or docs

Required proof pools

  • windows-clean-installer-upgrade: signed uninstall/upgrade, consent, cancellation and preservation. Blocked.

Validation

Capture passed. Prior WSL setup E2E: 4 failures. Prior native/process soak: 250 passes.

Local commands blocked: no PowerShell/.NET.
ClawSweeper reviewed 85c5b34: no actionable findings.

Real Behavior Proof

  • Environment tested: disposable hosted Windows; full installed Inno payload.
  • PR head or commit tested: 85c5b34; baseline 66b9b5a.
  • Exact steps or command run: historical capture at 85c5b34; Cancel, keep, reinstall, remove. Capture tooling removed; product/tests unchanged.
  • Evidence after fix: PNG/MP4 above; 397,397,365 bytes removed.
  • Observed result: settings/sentinel retained; Gateway choice No.
  • Screenshot or artifact links verified? Images/video inspected; public bytes verified.
  • Not verified: signed upgrade, mid-scan UI cancellation, compiler descendants, native/WSL wording, temp lifecycle.

Security Impact

  • New permissions or capabilities? Yes; opt-in file deletion, no elevation.
  • Secrets or tokens handling changed? No.
  • New or changed network calls? No.
  • Command or tool execution surface changed? Yes; bounded PowerShell helper.
  • Data access scope changed? Yes; pinned Kokoro files only.
  • If any answer is Yes, explain the risk and mitigation: unchecked consent, hash/handle verification, migration checks; failures retain files.

Compatibility and Migration

  • Backward compatible? Intended; signed upgrade unverified.
  • Config or environment changes? Yes; optional bounded scan/process timeouts.
  • Migration needed? No.
  • If yes, list the exact upgrade steps: N/A.

Managed publication used an upstream branch; the required fork-source workflow remains unresolved.

Review Conversations

  • I replied to or resolved every bot review conversation addressed by this PR.
  • I left unresolved only conversations that still need maintainer judgment.

Contributor credit

Donniefi supplied requirements; jalehman authorized capture publication; RoboClaw implemented.

Work sessions

Linked for team reference; these sessions aren’t public.

🦞 Made with OpenClaw

Worked on by

Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:feature Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. and removed clawsweeper:intake:feature Preliminary submission classification; full source review pending. labels Nov 19, 2026
@clawsweeper

clawsweeper Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR adds an optional Inno uninstall choice to preview and remove verified Kokoro voice downloads while keeping other data.

Example: Uninstall Companion with the English/Chinese Kokoro pack occupying 397,397,365 bytes.

  • Before: The downloaded model and voices remain without an uninstall removal choice.
  • After: The user can preview their paths and measured sizes, then explicitly select removal; keeping them remains the default.

Review scores

Measure Result What it means
Overall readiness 🦪 silver shellfish (2/6) Useful, focused production behavior with meaningful installed UI evidence and no identified code blocker, but required installer acceptance remains incomplete and CI failure attribution is unresolved.
Proof confidence 🦪 silver shellfish (2/6) Real behavior proof is not required for maintainer- or bot-authored pull requests.
Patch quality 🦐 gold shrimp (3/6) No actionable review findings were identified.

Product

Kind: Feature · Worth it: Yes · Fix scope: Partial
User problem: Users uninstalling Companion to reclaim space cannot choose to remove roughly 379 MiB of downloaded Kokoro files.
Reason: The measured use case supports the maintainer-authorized opt-in direction, while Related linkage correctly leaves the broader issue open.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it delivers a useful uninstall feature absent from main, and no actionable introduced code defect was found; it remains a draft with an unresolved required CI failure.

Priority: P2
Reviewed head: 85c5b34b9cf1609d05113804a63b620b066373a0

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: Supply current-head signed release upgrade/uninstall evidence with retained settings and data, plus installed-dialog cancellation during an active scan; screenshots, recordings, or logs should redact credentials and non-public endpoints.
Agent review details

How this fits together

The Inno uninstaller owns consent and migration admission, launches a bounded PowerShell helper, and receives a completion report from shared code that verifies and optionally deletes fixed Kokoro files.

flowchart TD
  A[Inno uninstall] --> B[Consent and preview dialog]
  B --> C[PowerShell supervisor]
  C --> D[File verification worker]
  E[Shared Kokoro catalog] --> D
  D --> F[Selected model files]
  C --> G[Completion summary]
Loading

Technical review

Best possible solution:

Keep consent in Inno, share Kokoro’s pinned catalog, and remove only selected verified downloads while preserving unrelated files and existing migration safeguards.

Do we have a high-confidence way to reproduce the issue?

This is a feature request: current main intentionally retains downloaded models, and DonnieFi’s released-version observation establishes the concrete disk-space use case.

Is this the best way to solve the issue?

The design uses the existing Inno consent and migration owners, preserves the downloader’s asset values, and supplies distinct native-file, process-completion, and packaging coverage without an unnecessary competing cleanup path.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against e9423aed4ba9.

Provenance checked

Testing

Proof path: shipped entry point.

Security

None.

Evidence

What I checked:

Likely related people:

  • Pedro Larroy: Raw commit 2a33672 adds src/OpenClaw.Shared/Audio/KokoroModelManager.cs:41 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 2a33672baedb; files: src/OpenClaw.Shared/Audio/KokoroModelManager.cs)
  • Natalie Aguinaldo: Raw commit 5a59535 adds installer.iss:203 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 5a59535216ee; files: installer.iss)
  • Ranjesh: Raw commit 8af4b70 adds installer.iss:105 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 8af4b70360a9; files: installer.iss)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Review metrics

Metric Value Why it matters
Change distribution Production +693/-10; tests +514; capture automation +1002; docs +4 Most growth supports installed behavior capture; the production additions serve consent, worker completion, shared catalog ownership, and bounded file deletion.

Labels

Label changes:

  • add rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • remove rating: 🧂 unranked krab: Current PR rating is rating: 🦪 silver shellfish, so this older rating label is no longer current.

Label justifications:

  • P2: Optional disk-reclamation functionality with preservation as the default and a limited uninstall-only scope.
  • rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🦐 gold shrimp.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (2 earlier review cycles)
  • reviewed 2026-11-19T00:29:21.479Z sha 34e9c52 :: needs changes before merge. :: [P1] [P1] Pass the required arguments to CreateCustomForm | [P2] [P2] Match hash nullability in the catalog comparison | [P2] [P2] Keep the dialog interactive while the preview helper runs
  • reviewed 2026-11-20T01:04:48.540Z sha eb9e7fa :: needs maintainer review before merge. :: none

Reviewed November 20, 2026, 6:46 AM ET / 11:46 UTC (Revision 3).

Copy link
Copy Markdown
Contributor

Additional baseline evidence from @DonnieFi’s Windows 11 Petty run (Companion 2026.11.3): after uninstall from Windows Settings, %APPDATA%\OpenClawTray\models still contained two files totaling 397,397,365 bytes (~379 MiB). The app and native Gateway were removed, but uninstall first required ending the still-running Companion process. This is the original observation behind #2286, not an independent reproduction or a test of this PR.

The redacted Focus Week capture includes a report, timeline, commands and logs (private evidence run 96258ccb-29f2-41f3-b799-1f002bc2e5cb); its completion inventory and object metadata are present in R2. The screenshot in that capture shows the earlier blocked uninstall, not this PR’s model dialog. No reboot/logon test was performed in that run.

This supports the user need; it does not establish current-head behavior, resolve the compilation or cancellation findings, or provide signed-installer proof. A later read-only check found no running OpenClaw process, service, installed Appx package or uninstall entry on Petty; the two model files and an inactive scheduled task remain. Petty may be suitable for a new Windows validation pass once a buildable revision and appropriate test installer are available.

roboclaw-bot and others added 2 commits November 20, 2026 00:22
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by:
- @DonnieFi

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
@roboclaw-bot

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Nov 20, 2026
roboclaw-bot and others added 5 commits November 20, 2026 08:17
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 66d9096b-d3fe-4c66-b2dd-9fde3bfa10f1
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: a09a0987-df78-4fe0-8ee4-cbfeee98d3ef
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 4a214e0c-e5d3-452c-994e-e9056e0aa345
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: ee2d8088-cf37-4c29-9335-afe975fb1cad
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: c0cd2cec-53b7-4729-a978-18e339f4b8c8
@roboclaw-bot

Copy link
Copy Markdown
Contributor Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦞👀
Exact review queued.

Re-review progress:

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Nov 20, 2026
Worked on by:
- @DonnieFi
- @jalehman

Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com>
Co-authored-by: jalehman <550978+jalehman@users.noreply.github.com>
OpenClaw-Publication: 5f887b48-f20a-4bdf-bb7e-d519400e5c1d
@jalehman
jalehman marked this pull request as ready for review November 20, 2026 18:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants