Repository navigation
feat: offer selective voice-model removal when uninstalling Companion - #2328
roboclaw-bot wants to merge 9 commits into
Conversation
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 73d4d23a-1d56-4b8d-91f3-1b381396c797
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesThis PR adds an optional Inno uninstall choice to preview and remove verified Kokoro voice downloads while keeping other data. Example: Uninstall Companion with the English/Chinese Kokoro pack occupying 397,397,365 bytes.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Partial Merge readiness✅ Ready for maintainer review Keep this PR open: it delivers a useful uninstall feature absent from main, and no actionable introduced code defect was found; it remains a draft with an unresolved required CI failure. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe Inno uninstaller owns consent and migration admission, launches a bounded PowerShell helper, and receives a completion report from shared code that verifies and optionally deletes fixed Kokoro files. flowchart TD
A[Inno uninstall] --> B[Consent and preview dialog]
B --> C[PowerShell supervisor]
C --> D[File verification worker]
E[Shared Kokoro catalog] --> D
D --> F[Selected model files]
C --> G[Completion summary]
Technical reviewBest possible solution: Keep consent in Inno, share Kokoro’s pinned catalog, and remove only selected verified downloads while preserving unrelated files and existing migration safeguards. Do we have a high-confidence way to reproduce the issue? This is a feature request: current main intentionally retains downloaded models, and DonnieFi’s released-version observation establishes the concrete disk-space use case. Is this the best way to solve the issue? The design uses the existing Inno consent and migration owners, preserves the downloader’s asset values, and supplies distinct native-file, process-completion, and packaging coverage without an unnecessary competing cleanup path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against e9423aed4ba9. Provenance checked
TestingProof path: shipped entry point. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (2 earlier review cycles)
Reviewed November 20, 2026, 6:46 AM ET / 11:46 UTC (Revision 3). |
|
Additional baseline evidence from @DonnieFi’s Windows 11 Petty run (Companion 2026.11.3): after uninstall from Windows Settings, The redacted Focus Week capture includes a report, timeline, commands and logs (private evidence run This supports the user need; it does not establish current-head behavior, resolve the compilation or cancellation findings, or provide signed-installer proof. A later read-only check found no running OpenClaw process, service, installed Appx package or uninstall entry on Petty; the two model files and an inactive scheduled task remain. Petty may be suitable for a new Windows validation pass once a buildable revision and appropriate test installer are available. |
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 2ec673e9-a7a4-4a0d-898c-50cd68c59447
Worked on by: - @DonnieFi Co-authored-by: DonnieFi <44792682+DonnieFi@users.noreply.github.com> OpenClaw-Publication: 49448427-c9c4-471b-884d-52cf8d17167b
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
What Problem This Solves
Related: #2286
Adds opt-in Kokoro cleanup with measured previews.
Draft: signed upgrade proof and four WSL E2E failures remain open.
User Impact
Default: keep models, including silent uninstall. Preview paths/bytes before consent. Other data and Gateway removal stay separate.
Why This Change Was Made
Async preview; atomic worker receipts. Deletion rechecks hashes, pinned paths and migration; no recursion.
Evidence
Real installed UI: signed baseline vs unsigned Dev. Keep, Cancel, and removal passed; settings/sentinel preserved.
Before

After

Video (cropped, 16 seconds):
https://github.com/user-attachments/assets/06411dad-c32b-43cd-abce-90487100b8af
Change Type
Scope
winnodeRequired proof pools
windows-clean-installer-upgrade: signed uninstall/upgrade, consent, cancellation and preservation. Blocked.Validation
Capture passed. Prior WSL setup E2E: 4 failures. Prior native/process soak: 250 passes.
Local commands blocked: no PowerShell/.NET.
ClawSweeper reviewed
85c5b34: no actionable findings.Real Behavior Proof
85c5b34; baseline66b9b5a.85c5b34; Cancel, keep, reinstall, remove. Capture tooling removed; product/tests unchanged.Security Impact
Yes, explain the risk and mitigation: unchecked consent, hash/handle verification, migration checks; failures retain files.Compatibility and Migration
Managed publication used an upstream branch; the required fork-source workflow remains unresolved.
Review Conversations
Contributor credit
Donniefi supplied requirements; jalehman authorized capture publication; RoboClaw implemented.
Work sessions
Linked for team reference; these sessions aren’t public.
Discussion, implementation and verification
Capture implementation
🦞 Made with OpenClaw
Worked on by