Repository navigation
Keep compaction and Structured Outputs checks across the getter migration - #1371
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved after coordinator and independent static review. Reviewed all three changed files and the compatibility-policy caller. Migration remains restricted to next and matching old/new list-accessor transitions; both the policy and selected patch come from the trusted base. The optional-getter adaptation preserves message IDs, exact list cardinality and the compaction trigger assertion through JsonValue normalization. Archived staging and symlink checks remain intact, and regressions preserve working/proposed fixtures while rejecting candidate-supplied patch content. No actionable findings.
Reviewed commit: a8d4b8a. Hosted CI: 4 in_progress, 2 success. No candidate code, generators, patch replay or local tests executed.
dpiet-oai
changed the title
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed b3be793. The next-only getter migration now checks exact generic declarations and JVM descriptors against the trusted baseline profile, retains unrelated compatibility failures, and preserves the prior compaction-fixture assertions. All seven authored files are unchanged by the merge from next. No actionable findings. Hosted CI currently has four successful and two in-progress checks. Static review only; no candidate code or local tests executed.
Exact commit b3be793. Coordinator and independent static review; no candidate code, builds or local tests executed. Hosted checks at publication: 5 in_progress, 3 queued, 5 success.
Keep the archived compaction and Structured Outputs compatibility checks executable when Java next adopts optional primary getters and throwing accessors.
The compaction helper retains the historical GA and beta output assertions and the trigger tag assertion. The Structured Outputs detector keeps the current baseline. On pull requests and merge groups targeting next, loss of a listed getter requires the complete successor getter profile from the trusted base. It checks the generic public declaration and JVM descriptor for both accessors and the raw constant readers. The proposed manifest still has to match the compiled classes exactly.
The compiled Structured Outputs inventory changes from 654 descriptors to 724 across the same 15 classes. Five wrappers account for all 22 replacements and 92 additions. The other 632 descriptors remain required. The 37 policy tests passed. An artifact replay checked five branch/event modes, rejected individual removals of all 135 successor declarations, and checked populated, absent and null values through a real structured wrapper. The compaction tests also rejected wrong GA and beta IDs and a wrong trigger tag.