Repository navigation
feat(api): deprecate closed enum projections on string wrappers - #1370
Conversation
Castiron-Internal-PR: openai/openai-java-internal#455 Castiron-Source-SHA: 6a50fb7c2b5564a87f8abea637f983fc9245e5d9 Castiron-Public-Base-SHA: 4a41191
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved at 2ffd05f. Reviewed all 499 changed paths, including 4,412 warning-level deprecation annotations across 493 model files. Existing constants, enum types, accessors, signatures and runtime behavior are preserved. Reviewed the migration guidance, enclosing-class ProGuard retention, both test reliability fixes and generated manifest changes. All changed blobs and the base match the reviewed internal change. No actionable findings.
Coordinator and independent static review. Hosted CI has four passing checks and two pending checks. No candidate code, generators or local tests executed.
Summary
Existing string-backed wrappers now guide callers toward comparisons that handle new values from the API.
Changes