Skip to content

feat(api): deprecate closed enum projections on string wrappers - #1370

Merged
dpiet-oai merged 1 commit into
nextfrom
castiron/promotions/pr-455
Nov 10, 2026
Merged

dpiet-oai merged 1 commit into
nextfrom
castiron/promotions/pr-455

Conversation

@dpiet-oai

Copy link
Copy Markdown
Contributor

Summary

Existing string-backed wrappers now guide callers toward comparisons that handle new values from the API.

Changes

  • Deprecate Known, Value, known(), and value() on existing string-backed wrappers while preserving their constants and methods.
  • Add Java and Kotlin migration examples for comparing named constants, handling unknown strings, and inspecting raw JSON.
  • Keep enclosing-class metadata for SDK models in applications that use a code shrinker.

Castiron-Internal-PR: openai/openai-java-internal#455
Castiron-Source-SHA: 6a50fb7c2b5564a87f8abea637f983fc9245e5d9
Castiron-Public-Base-SHA: 4a41191
@dpiet-oai
dpiet-oai requested a review from a team as a code owner November 10, 2026 21:53
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T21:54:39.646339Z 2ffd05f PR opened
🔒 Security Review ✅ Completed 2026-11-10T21:55:32.792737Z 2ffd05f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 2ffd05f. Reviewed all 499 changed paths, including 4,412 warning-level deprecation annotations across 493 model files. Existing constants, enum types, accessors, signatures and runtime behavior are preserved. Reviewed the migration guidance, enclosing-class ProGuard retention, both test reliability fixes and generated manifest changes. All changed blobs and the base match the reviewed internal change. No actionable findings.

Coordinator and independent static review. Hosted CI has four passing checks and two pending checks. No candidate code, generators or local tests executed.

@dpiet-oai
dpiet-oai merged commit fd601ba into next Nov 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants