Repository navigation
Make LifeCycleEvents constants switchable again - #1815
Merged
Merged
Conversation
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the public fullEventType(String) overload breaks source and binary compatibility for existing clients, so it must be retained alongside the new enum overload.
1 open issue
What changed in this PR
Restores compile-time constants in LifecycleEvents so SDK consumers can use them in Java switch labels while preserving existing event strings.
Changes:
- Extracts literal prefixes and event suffixes into nested
Constantsclasses. - Uses those literals to initialize
LifecycleEventsconstants. - Changes event-type formatting to accept
EventTypeand updates publisher calls.
| File | Description |
|---|---|
impl/core/src/main/java/org/openworkflow/sdk/impl/LifecycleEvents.java |
Uses constant expressions for switch-compatible event names. |
impl/core/src/main/java/org/openworkflow/sdk/impl/lifecycle/LifeCycleEventType.java |
Exposes prefix constants and changes the formatting method parameter. |
impl/core/src/main/java/org/openworkflow/sdk/impl/lifecycle/EventType.java |
Extracts event suffix constants and adjusts string formatting. |
impl/core/src/main/java/org/openworkflow/sdk/impl/lifecycle/ce/AbstractLifeCyclePublisher.java |
Passes enum values directly to the formatting method. |
Review effort: Balanced
Comment on lines
+33
to
35
| public String fullEventType(EventType eventType) { | ||
| return prefix + eventType.type(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.