[fjtirado]

Fix #1773

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[mathecruz]

LGTM

[Copilot]

🟡 Changes recommended

Method-call initializers make all fourteen public lifecycle type fields non-constant, breaking compilation for consumers that use them as switch labels or annotation values.

1 open issue

• Preserve compile-time constants for lifecycle type fields · New

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The event-type helper omits V7 types, preventing listeners registered through it from receiving legacy events, and the V7-only and dual-publication paths lack regression coverage.

1 open issue

• Preserve compile-time constants for lifecycle type fields

2 previously missed issues

In code that hasn't changed since last review

Lifecycle event helper omits legacy V7 event types

impl/​core/​src/​main/​java/​org/​openworkflow/​sdk/​impl/​lifecycle/​ce/​AbstractLifeCyclePublisher.java:52

EventType.toString() always uses V8, so this helper omits every legacy type even when V7 publication is enabled. Consumers registering listeners through this list, as LifeCycleEventsTest.init() does, will never receive the legacy events; with V7-only configuration they receive no lifecycle events at all. Include both supported prefixes here, or add an overload that enumerates the application's configured prefixes.

Add lifecycle test coverage for V7 and dual publication

impl/​core/​src/​main/​java/​org/​openworkflow/​sdk/​impl/​lifecycle/​ce/​AbstractLifeCyclePublisher.java:292

The existing lifecycle tests exercise only the default V8 configuration, and no test calls withLifeCycleEventTypes. The new V7 and dual-publication paths therefore have no regression coverage. Extend LifeCycleEventsTest to cover V7-only and V7+V8 configurations, asserting the exact emitted types, event counts, and matching payloads, while retaining the default V8 assertion.

_{Review effort: Balanced}