Repository navigation
[SDK] Clamp BatchLogRecordProcessor batch size to queue size - #4768
Open
Syedowais312 wants to merge 4 commits into
Open
Syedowais312 wants to merge 4 commits into
Syedowais312 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4768 +/- ##
==========================================
+ Coverage 86.61% 86.61% +0.01%
==========================================
Files 530 530
Lines 21169 21176 +7
==========================================
+ Hits 18333 18340 +7
Misses 2836 2836
🚀 New features to boost your workflow:
|
proost
reviewed
Nov 7, 2026
mateenali66
approved these changes
Nov 7, 2026
mateenali66
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the fix.
At d94b0c19 the three oversized cases fail without the clamp, and the clamp tests pass 30 repeats under TSan.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4750
Changes
Clamp
max_export_batch_sizeto a non-zeromax_queue_sizeand emit one warning in all threeBatchLogRecordProcessorconstructors, matching #4727 forBatchSpanProcessor.Valid batch sizes and zero-sized queues retain their existing behavior. Update the options documentation and changelog.
Add tests covering oversized batches, valid batches, and zero-sized queues across all three constructors. All 27 tests in
batch_log_record_processor_testpass; the three oversized-batch cases fail without the fix.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes