Skip to content

fix(i18n): add missing zh-TW key chatWindow.subagentCompletedSummary - #545

Open
kahme247 wants to merge 1 commit into
mainfrom
fix-zhtw-subagent-summary-2026-11-22
Open

kahme247 wants to merge 1 commit into
mainfrom
fix-zhtw-subagent-summary-2026-11-22

Conversation

@kahme247

@kahme247 kahme247 commented Nov 22, 2026 •

Copy link
Copy Markdown
Collaborator

PR #440 added chatWindow.subagentCompletedSummary to en, ja and zh-CN but not zh-TW, so lib/i18n.test.mjs (zh-TW keys must match en exactly) fails on main — Verify run #2005 went red on all three platforms.

This adds the missing key to lib/i18n/locales/zh-TW.json in the same position as en.json, value 已完成 {completed}/{total} (same characters as zh-CN, already valid Traditional Chinese).

Verified locally: the file parses and its key set now matches en.json exactly (no missing, no extra).

Summary by CodeRabbit

  • Localization
    • The Traditional Chinese chat window now includes a translation for the summary showing how many subagents have completed out of the total. This makes the completed and total counts visible in Traditional Chinese when that summary is displayed.

@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Adds a Traditional Chinese chat window translation that displays the completed subagent count and total subagent count.

Changes: Chat localization

Layer / File(s) Summary
Subagent completion translation
lib/i18n/locales/zh-TW.json
Adds chatWindow.subagentCompletedSummary with {completed} and {total} placeholders.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: andrebrait

Merge Risk: Minimal · up to b64ee

This adds the missing Traditional Chinese text for the completed subagent count and restores locale key parity. The text keeps the count placeholders, so merge risk is minimal.

Architecture risk: Low · up to b64ee

The change affects 1 system.

Changed systems: lib

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — lib (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in lib/i18n/locales/zh-TW.json: 新增 chatWindow.subagentCompletedSummary 翻譯字串,包含 {completed} 與 {total} 計數佔位符。
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change accurately: it adds the missing zh-TW translation key chatWindow.subagentCompletedSummary. The raw summary confirms that the only change is one added line in lib/i18n/locale…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change accurately: it adds the missing zh-TW translation key chatWindow.subagentCompletedSummary. The raw summary confirms that the only change is one added line in lib/i18n/locales/zh-TW.json, and the PR objectives describe the same key addition to match en.json. The title uses the conventional fix(i18n) prefix and stays within a single line, so it covers the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9aed8389-1a61-4123-bae8-77f4e8dd755d
Commits

Reviewing files that changed from the base of the PR and between 049dbf6 and b64ee10.

Files selected for processing: 1

  • lib/i18n/locales/zh-TW.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant