Repository navigation
Conversation
Details: - See PR 42793 in neovim/neovim
|
The fix might be simpler: H.unecho = function()
-- if H.cache.msg_shown then vim.cmd([[echo '' | redraw]]) end
if H.cache.msg_shown then vim.cmd([[redraw | echo '']]) end
end
All tests in test_align succeed using all supported Neovim versions. I also ran the failing test by hand. After pressing |
Hmm... If that is the case, that's great. It's just slightly suspicious that this order works, since the logical order of things is "first show message, then ensure it is shown by redraw". But Vim screen drawing might have some parts that don't look logical at first. I'll need to take a closer look, since that order was chosen for (some) reason. |
Its' used in quite some places. In
|
|
This should now be resolved on the latest Thanks for finding the culprit. It made finding the solution much easier :) |
My pleasure! |
Details:
Failing test: T['Align with preview']['works'], only when parametrized with 'Normal-*'. In the fifth screenshot the command line is not cleared.
I replayed the test manually step by step and everything seems to work correctly. So, perhaps this is 'rpc' related. I could not apply a fix in the test itself unfortunately. An extra
H.unecho()does the trick. Perhaps there is a better solution?