Repository navigation
feat(proxy): add proxy.origin for a separate client-facing proxy origin - #973
Conversation
`proxy.origin` resolves the client proxy prefix against another host, so the intercept plugin, bundle rewrites, auto-injected endpoints, the GA proxy endpoint and Partytown `resolveUrl` emit `https://<origin>/_scripts/p/...`. The server route, server proxy config, bundled assets and devtools keep the relative prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@felixgabler is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 7 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly and concisely identifies the main change: adding proxy.originfor a separate client-facing proxy origin.Description check The description directly explains the proxy.originbehaviour, affected client-facing consumers, unchanged server-side behaviour, and test coverage.Linked Issues check Issue #972requires optionalproxy.originsupport for client-facing proxy URLs, including the intercept plugin, bundle rewrites,proxyEndpoints,applyAutoInject, and Partytown. The PR summary re…Out of Scope Changes check The changes stay within issue #972. The implementation adds the requested proxy-origin behaviour. The documentation describes the new option and its cross-origin requirement. The fixture and unit test…Full details: Linked Issues check
-
Explanation
Issue
#972requires optionalproxy.originsupport for client-facing proxy URLs, including the intercept plugin, bundle rewrites,proxyEndpoints,applyAutoInject, and Partytown. The PR summary reportsorigin?: string, client-prefix resolution, absolute-target handling in AST rewrites, and the intercept guard for already-proxied URLs. It also reports that server routes, the private proxy prefix, bundled assets, and devtools remain relative. The added tests cover absolute and relative rewrites, intercept runtime cases, and absolute GA and Plausible endpoints with the relative route still active.
Full details: Out of Scope Changes check
-
Explanation
The changes stay within issue
#972. The implementation adds the requested proxy-origin behaviour. The documentation describes the new option and its cross-origin requirement. The fixture and unit tests verify the requested client and server URL behaviour. No unrelated product or infrastructure changes are identified.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 62.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 7 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
📦 Package Size📚 22 runtime dependencies (no change)
All tracked output (25)
Runtime dependencies (22)
Baseline: main_@_321e7574___2026-10-13 · gzip is the comparison metric · changes below 16 B gzip are ignored |
harlan-zw
added
harlan-agent-review
🤖 MERGED
GitHub merged this pull request.
60df4be9-2b1b-424e-a6f0-ed6c558d57a2 Selected findings run after merge and open separate pull requests. |
harlan-zw
added
harlan-agent-ready
|
Awesome work, thanks 🙌 |
harlan-zw
removed
the
harlan-agent-ready
Fixes #972
The first-party proxy builds every client-facing URL from
location.origin: the intercept plugin, bundle rewrites (self.location.origin+...) and the GAproxyEndpoints. The proxy therefore cannot live on another host, for example a tracking subdomain that points at the same deployment.This adds an optional
proxy.origin. When it is set, the module resolves a client prefixnew URL(proxyPrefix, origin).hrefand hands it to every client-facing consumer. AST rewrites drop theself.location.origin+prefix when the rewrite target is already absolute. The intercept plugin builds proxied URLs withnew URL(..., location.origin)and leaves URLs that already point at the proxy unchanged.The server handler route, the server-side proxy config, bundled assets and devtools keep the relative prefix, so nothing changes when
originis unset.proxyUrloriginwhen set)applyAutoInject)proxyEndpoints.googleAnalyticsresolveUrl<prefix>/p/**runtimeConfig['nuxt-scripts-proxy'].proxyPrefixbuildAssetUrl)Tests: AST rewrite cases for absolute and relative targets, intercept
proxyUrlruntime cases, and theproxy-aliasfixture now setsoriginto assert the absolute GA and Plausible endpoints while the relative server route still answers.