Skip to content

fix(nitro): stop registering deprecated rollup:before hook on Nitro v3 - #1683

Merged
danielroe merged 1 commit into
mainfrom
nitro-v3-build-hook
Nov 17, 2026
Merged

danielroe merged 1 commit into
mainfrom
nitro-v3-build-hook

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

on nitro v3, registering rollup:before prints a deprecation warning, so this registers a hook conditionally

@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The watcher now selects Nitro build hooks by major version. Nitro 3 uses build:config; other versions use rollup:before. A typed hook interface supports registration. Tests check the registered hooks and their building state for Nitro v2 and v3.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to 462a0

This change stops registering the deprecated rollup:before hook on Nitro v3 and uses build:config there instead. No concrete merge-blocking risk was found. In the worst case the deprecation warning still appears on some Nuxt versions.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the PR stops registering the deprecated rollup:before hook on Nitro v3. The raw summary confirms that #watchServerBuilds now selects build:config on Nitro 3 and …
Description check Passed The description states that on Nitro v3, registering rollup:before prints a deprecation warning, and that the PR registers the hook conditionally. This matches the changeset, which selects hooks by …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the PR stops registering the deprecated rollup:before hook on Nitro v3. The raw summary confirms that #watchServerBuilds now selects build:config on Nitro 3 and keeps rollup:before for other versions. The title is specific and matches the changeset and the stated objective.

Full details: Description check

Explanation

The description states that on Nitro v3, registering rollup:before prints a deprecation warning, and that the PR registers the hook conditionally. This matches the changeset, which selects hooks by Nitro major version. The linked issue section still contains the template placeholder and no issue number, but the check is lenient and the description relates to the change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bb42e77a-ad71-4152-a19e-66c0731ad0cd
Commits

Reviewing files that changed from the base of the PR and between c33f0cf and 462a066.

Files selected for processing: 2

  • packages/nuxt-cli/src/dev/utils.ts
  • packages/nuxt-cli/test/unit/dev/lifecycle.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1683
    
    npm i https://pkg.pr.new/nuxi@1683
    
    npm i https://pkg.pr.new/@nuxt/cli@1683
    

commit: 462a066

@codspeed

codspeed Bot commented Nov 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Upgrade your CodSpeed plugin for Node.js 24

@codspeed/* 5.7.1 is only tested on Node.js 18, 20, and 22, so your Node.js 24 measurements may be inaccurate. Upgrade your @codspeed/* packages to 6.0.0 or later.

See affected benchmarks

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 2 untouched benchmarks


Comparing nitro-v3-build-hook (462a066) with main (c33f0cf)

Open in CodSpeed

@github-actions

Copy link
Copy Markdown
Contributor

CLI benchmark

@nuxt/cli v4.1.0-alpha.0 (baseline) vs v4.1.0-alpha.0 (this PR)

Metric baseline v4.1.0-alpha.0 head v4.1.0-alpha.0 Delta
nuxt --version wall time (median) 66 ms 67 ms +1.3%
nuxt --help wall time (median) 142 ms 142 ms -0.1%
nuxt dev --help wall time (median) 107 ms 105 ms -1.2%
nuxt --version modules loaded 35 35 0.0%
nuxt --version built-ins loaded 29 29 0.0%
nuxt --help modules loaded 137 137 0.0%
nuxt --help built-ins loaded 93 93 0.0%
nuxt dev --help modules loaded 65 65 0.0%
nuxt dev --help built-ins loaded 90 90 0.0%
Installed node_modules 2.56 MB 2.56 MB +0.0%
Published tarball (packed) 248.9 kB 249.0 kB +0.0%
Full report

@nuxt/cli v4.1.0-alpha.0 (baseline) vs v4.1.0-alpha.0 (head)

Setting Value
Baseline ref:c33f0cf6e01a671f2c776ad63443985e23dbfc48 (v4.1.0-alpha.0)
Head local packages/nuxt-cli at 40d6860 (v4.1.0-alpha.0)
Node v24.22.3
OS Linux 7.0.0 (kernel 7.0.0-1019-azure)
CPU AMD EPYC 7763 64-Core Processor x 4
Memory 15.6 GB
Load average at start 0.95, 0.50, 0.21
Run started 2026-11-17T17:56:42.535Z

Cold CLI startup

Median of 15 interleaved runs per command, one warmup discarded.

Command baseline v4.1.0-alpha.0 median head v4.1.0-alpha.0 median Delta baseline v4.1.0-alpha.0 min / p95 head v4.1.0-alpha.0 min / p95
nuxt --version 66 ms 67 ms +1.3% 64 ms / 69 ms 62 ms / 69 ms
nuxt --version (first output byte) 62 ms 62 ms +0.6% 60 ms / 65 ms 58 ms / 65 ms
nuxt --help 142 ms 142 ms -0.1% 139 ms / 148 ms 141 ms / 144 ms
nuxt --help (first output byte) 136 ms 137 ms +0.3% 133 ms / 141 ms 135 ms / 139 ms
nuxt dev --help 107 ms 105 ms -1.2% 103 ms / 108 ms 102 ms / 108 ms
nuxt dev --help (first output byte) 101 ms 100 ms -1.4% 98 ms / 103 ms 97 ms / 102 ms
nuxt <unknown-command> (no-op) 151 ms 151 ms -0.1% 147 ms / 154 ms 147 ms / 154 ms
nuxt <unknown-command> (no-op) (first output byte) 145 ms 145 ms +0.2% 141 ms / 147 ms 141 ms / 148 ms

Module load cost

Counted with a module.registerHooks load hook, compile cache disabled. Counts every JS module actually evaluated on that code path (native addons excluded). Built-ins loaded after bootstrap are counted separately, including the internal modules they load.

Command baseline v4.1.0-alpha.0 modules head v4.1.0-alpha.0 modules Delta baseline v4.1.0-alpha.0 source bytes head v4.1.0-alpha.0 source bytes Delta baseline v4.1.0-alpha.0 built-ins head v4.1.0-alpha.0 built-ins Delta
nuxt --version 35 35 0.0% 301.2 kB 301.2 kB 0.0% 29 29 0.0%
nuxt --help 137 137 0.0% 870.1 kB 870.1 kB 0.0% 93 93 0.0%
nuxt dev --help 65 65 0.0% 464.1 kB 464.1 kB 0.0% 90 90 0.0%

Install footprint and published tarball

Each version installed on its own into an empty project with nothing but @nuxt/cli as a dependency, so the tree is exactly the CLI and its transitive dependencies. npm cache is warm and the registry is only consulted for metadata, so install wall time is indicative, not a network benchmark.

Metric baseline v4.1.0-alpha.0 head v4.1.0-alpha.0 Delta
Direct dependencies of @nuxt/cli 23 23 0.0%
Packages in the installed tree (unique name@version) 38 38 0.0%
Unique package names 38 38 0.0%
Package directories on disk (cross-check) 32 32 0.0%
Installed node_modules on disk 2.56 MB 2.56 MB +0.0%
Installed files 443 443 0.0%
Install wall time (warm npm cache, median of 3) 1.43 s 1.42 s -0.8%
Published tarball (packed) 248.9 kB 249.0 kB +0.0%
Published tarball (unpacked) 805.7 kB 805.9 kB +0.0%
Files in tarball 105 105 0.0%

Interleaved runs on a shared runner: trust the deltas, not the absolute timings. The dev, restart and build suites run locally via pnpm bench:cli.

@danielroe
danielroe added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 4595699 Nov 17, 2026
26 checks passed
@danielroe
danielroe deleted the nitro-v3-build-hook branch November 17, 2026 18:31
@github-actions github-actions Bot mentioned this pull request Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant