Repository navigation
Don't fail clients for whitespace after a value - #16
Merged
Merged
Conversation
Calva and Conjure ask for values printed with cider-nrepl's pprint, which ends every value with a newline (orchard.pp prints one after it). Babashka 1.13.227 implements that printer the same way, so calva.eval, conjure.eval and their load-file checks failed it for "3\n", which is just what nREPL with cider-nrepl gives those clients too. Client profile steps now ignore whitespace after a value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babashka 1.13.227 started failing calva.eval and conjure.eval with the value
"3\n". That's what cider-nrepl'spprintgives Calva and Conjure on the JVM too, since orchard.pp ends every value with a newline, so it isn't worth even a warning.