Repository navigation
fix(index): one New board, always primary, Views buttons at the end - #68
Merged
Merged
Conversation
Findings from Beacon on the board list page, seen on 2.0.2 and still in 2.1.0.
With no boards the page drew New board twice, in the header and in the empty
state. The header's action now needs a board; the empty state takes the same
$canCreate and the scaffold draws it whenever there are no rows, so a list
emptied by the list check or by board access keeps the only button.
New board had no variant, so action_variants {create: secondary} turned the
page's main action secondary. UiKit's partial reads the explicit variant first
and its docs say Action::create() stays primary for this reason. The action
opens a dialog and has no href, so it sets variant: 'primary' directly.
The Views cell is end-aligned but its buttons stayed at the start. They now end
in that cell only, and stay at the start in a card, as the kit keeps every
end-aligned column there. A host's list via _board_list_item does not change.
Documents the contract Beacon relies on: any scope shows New board without
asking canCreateBoard(), so a provider returns [] on a tenant's page where the
user may not create.
…block table Audit HZ on PR #68: Pass (good) / Low, with two documentation findings. HZ-L2: returning [] from scopes() hands the decision to canCreateBoard() for the page's tenant; with a permissive checker the button shows and the create route creates there without resolve(). Says so in the docblock, CONFIGURATION, SECURITY and UPGRADING. HZ-L3: a templates.index override that skips page.empty loses the button like an empty partial without empty.action; only ?new=1 and the noscript form remain. USAGE listed the 1.x index blocks removed in 2.0.0; it now lists the 2.0 ones. Records the HZ verdict in SECURITY, CHANGELOG and UPGRADING.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beacon's findings on the board list page, reported on 2.0.2 and confirmed in the code of 2.1.0. Target: 2.1.1.
Changes
$canCreate. The page has no filter or search, and the scaffold draws the empty state wheneverpage.rowsis empty, so a list emptied bylist_rolesor by board access keeps the button._action.html.twigresolvesaction.variant ?: action_variants[kind], and UiKit documents that an explicit primary keeps the page's main action.Action::create()needs anhrefand this action opens a dialog, so it setsvariant: 'primary'. No other TaskBoard page has this gap: this is the onlycreatekind in the bundle..nowo-ui-cell--end, with a reset inside the card container query. Measured in Chromium: at 390 and 320 px the buttons sit at exactly the same coordinates as before.canCreateBoard(); a provider returns[]on a tenant's page where the user may not create. In the interface docblock andCONFIGURATION.md, becauseUSAGE.mddoes not describe scope providers.For hosts
nowo-task-board-newis gone andnowo-task-board-new-emptyis the only button.emptypartial must printempty.action.action_variants: {create: secondary}.No schema, configuration or permission change. Audit: re-verification pending, in the next batch.