Repository navigation
feat(tasks): readable task numbers and a calendar view (spec 214) - #64
Merged
Merged
Conversation
Task numbers (task_numbers.enabled): a #123 per tenant or per board, assigned at persistence by a Doctrine listener, with a counter and a ledger, so numbers are never reused and a task moved to another scope keeps the old one as an alias. The route task_by_number answers the same 404 for unknown, retired and unreadable numbers. A backfill command numbers older tasks. Calendar (calendar.enabled): month, week and list modes with server filters in the URL, a query bounded by the visible days, and the route task_schedule with TaskManager::reschedule(). Drag uses UiKit's sortable, with keyboard and dialog routes that need no pointer. No drag on phones. Both are opt-in. Every host adds the nullable column task_board_tasks.number. Audit status: pending batch audit.
…tarts HY-L1: task_schedule accepts only the years the calendar shows. HY-L2: purgeScope() refuses while a task still carries a number in the scope. HY-L3: a synced task with no start date keeps none, instead of the creation date. The Gantt still falls back to it through getPlannedStart(). Also: a task moved to a scope where its new number equals its old one now gets its ledger row there. The listener looked at the number's change, not the board.
… on mobile The ClickUp checklist parent check reads the id from the item instead of casting the array key: rector process removed that cast as useless, which brought the bug back. New test and fixture for an all-digit item that names itself as parent. A bad date on task_schedule says the dates could not be changed, instead of blaming the due date when the start was wrong. Rector's non-static failure(). The drag part of the board e2e is skipped on isMobile: a real device test decides it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 214 (Beacon
specs/214-readable-task-id-and-calendar), the TaskBoard part. Audit status: pending batch audit.Both features are opt-in. With
task_numbers.enabledandcalendar.enabledoff, no route, service, table or output changes. The one exception: every host adds the nullable columntask_board_tasks.number(DDL for MySQL, PostgreSQL and SQLite in UPGRADING).Numbers
#123per tenant or per board, assigned at persistence, so all four creation paths get one.nowo:task-board:numbers-backfill,TaskNumberLedger, routetask_by_number, and the number on the card, panel, list, subtask tree and Gantt tooltip.Calendar
task_scheduleandTaskManager::reschedule().sortable, edge drag, a Reschedule dialog, grid keyboard, and Undo through the kit's toast. No drag on phones.Tests
demo/symfony8/e2e/tests/calendar.spec.tsin Chromium, Firefox, WebKit and the phone profile.