Skip to content

test_runner: junit fixes - #67160

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:test-runner-junit-fixes
Open

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:test-runner-junit-fixes

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Fixes: #67155
Fixes: #67149

Adds sanitization + flushing to the Junit reporter, fixing the aforementioned issues.

Signed-off-by: avivkeller me@aviv.sh

Signed-off-by: avivkeller <me@aviv.sh>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@avivkeller
avivkeller marked this pull request as ready for review October 31, 2026 13:23

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not meant to be a draft...

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Oct 31, 2026
@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.68%. Comparing base (d44625a) to head (6eab3df).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67160      +/-   ##
==========================================
- Coverage   90.69%   90.68%   -0.02%     
==========================================
  Files         797      797              
  Lines      278787   278836      +49     
  Branches    53607    53620      +13     
==========================================
- Hits       252858   252855       -3     
- Misses      16292    16332      +40     
- Partials     9637     9649      +12     
Files with missing lines Coverage Δ
lib/internal/test_runner/reporter/junit.js 98.63% <100.00%> (+3.86%) ⬆️
lib/internal/test_runner/test.js 97.99% <100.00%> (+<0.01%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

2 participants