Skip to content

test: convert forEach to for of test-buffer-inheritance file - #67121

Open
antonioduran wants to merge 1 commit into
nodejs:mainfrom
antonioduran:test-buffer-inheritance-for-of
Open

antonioduran wants to merge 1 commit into
nodejs:mainfrom
antonioduran:test-buffer-inheritance-for-of

Conversation

@antonioduran

Copy link
Copy Markdown

test: convert forEach to for of test-buffer-inheritance file
Convert .forEach() to for...of in test/parallel/test-buffer-inheritance.js. Test code prefers for...of so a failing assertion has a clearer stack trace.

Verified with:

python3 tools/test.py parallel/test-buffer-inheritance

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Welcome to Node.js, and thank you for your first contribution!

Before review, please take a moment to read:

Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal.

Signed-off-by: Antonio Duran <ing.antonio.duran@gmail.com>
@antonioduran
antonioduran force-pushed the test-buffer-inheritance-for-of branch from 0b11904 to 0ea39db Compare October 29, 2026 21:54
@Ethan-Arrowood Ethan-Arrowood added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 29, 2026

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (510d84c) to head (0ea39db).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67121      +/-   ##
==========================================
+ Coverage   90.65%   90.66%   +0.01%     
==========================================
  Files         797      797              
  Lines      278783   278791       +8     
  Branches    53618    53613       -5     
==========================================
+ Hits       252718   252766      +48     
+ Misses      16420    16379      -41     
- Partials     9645     9646       +1     

see 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Ethan-Arrowood Ethan-Arrowood added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue PRs queued for automated landing through the Commit Queue. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants