Skip to content

deps: update timezone to 2026f - #67119

Open
nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/timezone-update
Open

nodejs-github-bot wants to merge 1 commit into
mainfrom
actions/timezone-update

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

This PR was generated by .github/workflows/timezone-update.yml and tools/dep_updaters/update-timezone.mjs.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

@nodejs-github-bot nodejs-github-bot added the dependencies PRs that add, update, or configure Node.js dependencies. label Oct 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2026
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@codecov

codecov Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (ee982db) to head (7c08f7c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67119      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.02%     
==========================================
  Files         797      797              
  Lines      278791   278791              
  Branches    53616    53615       -1     
==========================================
- Hits       252807   252769      -38     
- Misses      16334    16379      +45     
+ Partials     9650     9643       -7     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@richardlau

Copy link
Copy Markdown
Member
=== release test-datetime-change-notify ===
Path: parallel/test-datetime-change-notify
Error: --- stderr ---
node:internal/assert/utils:146
  throw error;
  ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

'10/29/2026, 7:49:38 PM GMT+00:00'

    at Object.<anonymous> (/home/runner/work/node/node/node/test/parallel/test-datetime-change-notify.js:36:10)
    at Module._compile (node:internal/modules/cjs/loader:1968:14)
    at Object..js (node:internal/modules/cjs/loader:2108:10)
    at Module.load (node:internal/modules/cjs/loader:1690:32)
    at Module._load (node:internal/modules/cjs/loader:1480:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:261:19)
    at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:173:5)
    at node:internal/main/run_main_module:33:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '10/29/2026, 7:49:38 PM GMT+00:00',
  expected: /Irish Standard Time|Greenwich Mean Time/,
  operator: 'match',
  diff: 'simple'
}

Node.js v28.0.0-pre
Command: out/Release/node /home/runner/work/node/node/node/test/parallel/test-datetime-change-notify.js

===
=== 1 tests failed
===

Failed tests:
out/Release/node /home/runner/work/node/node/node/test/parallel/test-datetime-change-notify.js
make: *** [Makefile:660: test-ci] Error 1

@richardlau

richardlau commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

So we've hit this failure before in #60523 (comment) and that was an ICU bug https://unicode-org.atlassian.net/browse/ICU-23278.

Given that it was an issue with metazone mapping, I'm wondering if the new timezone data needs some of the commits that landed on https://github.com/unicode-org/icu/commits/maint/maint-78/ since ICU 78.3.

cc @nodejs/i18n-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants