Repository navigation
[worker] Fix invalid JSON for RegExp CPU profile frames - #67103
Open
shahinsamiur wants to merge 1 commit into
Open
shahinsamiur wants to merge 1 commit into
shahinsamiur wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Signed-off-by: shahinsamiur <shahinsamiur@yahoo.com>
shahinsamiur
force-pushed
the
fix/worker-cpu-profile-json-escape
branch
from
October 29, 2026 10:01
bc1498e to
8ebd4ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67097.
CPU profile serialization currently writes function names, script URLs, and deoptimization reasons directly into JSON strings. RegExp frame names containing backslashes can therefore produce invalid JSON.
Add JSON string escaping to OutputStreamWriter and use it for these fields. Include a regression test for worker CPU profiles containing RegExp frames.