Repository navigation
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
mcollina
force-pushed
the
sea-vfs-code-cache
branch
2 times, most recently
from
October 15, 2026 15:58
a35d240 to
5ee0908
Compare
mcollina
force-pushed
the
sea-vfs-code-cache
branch
from
October 27, 2026 15:40
5ee0908 to
942338e
Compare
"useCodeCache" was rejected together with "useVfs" because the SEA code cache is only consumed by the embedder compile paths, while a main script in the VFS runs through the regular loaders and a main-only cache would not cover the modules it depends on anyway. Compile every JavaScript (and, with --strip-types, TypeScript) module in the VFS when the preparation blob is generated, without executing them, through a portable CompileCacheHandler keyed by the path relative to the mount point. The entries are serialized in the cache file layout and embedded as reserved node:sea:compile-cache/<key> assets, which the SEA provider hides from the mount. Modules that fail to compile are skipped. CompileCacheHandler gains a key root for portable caches and in-memory serialization of its entries, shared with Persist(). The build runs in a Node.js instance whose environment ignores NODE_COMPILE_CACHE. Reading the embedded entries at startup is left to a follow-up. Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
sea-vfs-code-cache
branch
from
October 27, 2026 16:03
942338e to
5d06ff8
Compare
ShogunPanda
approved these changes
Oct 27, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #66768 +/- ##
==========================================
- Coverage 90.65% 90.64% -0.02%
==========================================
Files 797 798 +1
Lines 278268 278618 +350
Branches 53517 53587 +70
==========================================
+ Hits 252261 252550 +289
- Misses 16386 16438 +52
- Partials 9621 9630 +9
🚀 New features to boost your workflow:
|
mcollina
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
ShogunPanda
approved these changes
Oct 28, 2026
mcollina
added
the
resume-ci
github-actions
Bot
added
resume-ci-failed
Contributor
Failed to resume CIFull Auto Start CI output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"useCodeCache": trueis currently rejected together with"useVfs": true. The reason is a plumbing gap rather than a V8 limitation: the SEA code cache is only consumed by the embedder compile paths (compileFunctionForCJSLoader(..., is_sea_main=true)and thekEmbedderbranch inmodule_wrap.cc), while a main script in the VFS runs through the regular CJS/ESM loaders. A main-only cache would also be of little use for a VFS bundle, where the dependency graph is what costs at startup.This PR implements the build-time half of the fix:
--build-sea/--experimental-sea-configspins up a Node.js instance (CommonEnvironmentSetup+LoadEnvironment), mounts the assets (or thevfsArchive) exactly like the runtime does, and compiles every.js/.cjs/.mjs(and.ts/.cts/.mtswith--strip-types) module in the mount without executing it, viawrapSafe/compileSourceTextModule, with a portableCompileCacheHandlerwhose keys are relative to the mount point.node:sea:compile-cache/<key>assets. The SEA provider hidesnode:sea:keys so they don't show up as files in the mount. Modules that fail to compile are skipped.CompileCacheHandlergains akey_rootfor portable caches andSerializeEntries(), which shares its serialization withPersist(). The internalenableCompileCachebinding takes the key root as a 4th argument.NODE_COMPILE_CACHE*is removed, so the user's compile cache settings cannot hijack the build.Reading the embedded entries at startup (a read-only, blob-backed
CompileCacheHandlerenabled frominitSeaVfs, including in workers undervfsArchive) is left to a follow-up PR, which will also decide whether the main-only code cache blob still needs to be generated under VFS.Tests:
test/sea/test-single-executable-application-vfs-code-cache.jschecks the number of embedded entries for the plain, ESM and ZIP fixtures (5/4/3), thatNODE_COMPILE_CACHE/NODE_DISABLE_COMPILE_CACHEin the build environment do not affect the result, and that the built executable still runs. The rejection case was removed fromtest-build-sea-vfs-incompatible-options.js. The existing VFS SEA tests andtest/parallel/test-compile-cache*pass.—-
AI generated, reviewed by me