Repository navigation
Add building by specific commit SHA - #31
Open
Ethan-Arrowood wants to merge 1 commit into
Open
Ethan-Arrowood wants to merge 1 commit into
Ethan-Arrowood wants to merge 1 commit into
Conversation
The core change is the Dockerfile and clone.sh now respect a `NODE_REF` value for building by the specified commit SHA When not specified, it defaults to the head commit of the main branch of `nodejs/node`. But the main intent for this feature is so that the `nodejs/node` repo can use `repository_dispatch` to automatically trigger new builds (with a specific commit hash) after successfully executing its own daily build workflow. Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Ethan-Arrowood
added a commit
to Ethan-Arrowood/node
that referenced
this pull request
Oct 31, 2026
Sends a node-daily event to the nodejs/devcontainer repo to trigger a new devcontainer build upon a successful daily build. It shares the specific associated commit so the exact devcontainer is built. Requires: nodejs/devcontainer#31 Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
Contributor
Author
|
Related to: nodejs/node#67153 |
Contributor
Author
|
I've also already created the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core change is the Dockerfile and clone.sh now respect a
NODE_REFvalue for building by the specified commit SHAWhen not specified, it defaults to the head commit of the main branch of
nodejs/node.But the main intent for this feature is so that the
nodejs/noderepo can userepository_dispatchto automatically trigger new builds (with a specific commit hash) after successfully executing its own daily build workflow.This change also merges the build workflows into one file to simplify things. It switches actions to using hashes for versions too (may want to consider installing a dep updater in this repo eventually).
Finally, I added some details to the README.md too.
I will be opening a PR on
nodejs/nodetoo shortly adding therepository_dispatchcall to the daily build workflow. Once these are both approved I'll have to update thenodejs-github-botto have write access onnodejs/devcontainer.Assisted-by: Claude Code