You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has annoyed me as well... ImGUI and GLM are the big culprits here.
#404 just merged adds the shallow tag to the git submodules, so git clone commands do a shallow submodule checkout by default. (Although some git commands don't respect this)
I also updated the docs to recommend a variant the CMake command you suggested. (I think the PATCH_COMMAND is slightly preferable to the full execute_process.)
As you say, this at least gets it down to ~80MB. Closing for now because I'm not sure what else to do. But please reopen if you or anyone else has any ideas.
I should also say: a more complete solution might be to totally stop using git submodules for our dependencies, and have Polyscope itself also fetch them via CMake. This is appealing in some ways because submodules are endlessly confusing for everyone involved.
However, I also fear it would break builds for users, which I'm really reluctant to risk. I'd at least wait for a major version bump. And I worried it might create more chaos for people who use build systems other than CMake. Happy to hear opinions on that from anyone finding this issue.
Activity
nmwsharp commentedon Sep 6, 2026
This has annoyed me as well... ImGUI and GLM are the big culprits here.
#404 just merged adds the
shallowtag to the git submodules, sogit clonecommands do a shallow submodule checkout by default. (Although some git commands don't respect this)I also updated the docs to recommend a variant the CMake command you suggested. (I think the
PATCH_COMMANDis slightly preferable to the fullexecute_process.)As you say, this at least gets it down to ~80MB. Closing for now because I'm not sure what else to do. But please reopen if you or anyone else has any ideas.
nmwsharp commentedon Sep 7, 2026
I should also say: a more complete solution might be to totally stop using git submodules for our dependencies, and have Polyscope itself also fetch them via CMake. This is appealing in some ways because submodules are endlessly confusing for everyone involved.
However, I also fear it would break builds for users, which I'm really reluctant to risk. I'd at least wait for a major version bump. And I worried it might create more chaos for people who use build systems other than CMake. Happy to hear opinions on that from anyone finding this issue.