Skip to content

Adding Burst with Conditional Trigger Example in NI-Digital - #2250

Draft
divakar-selvam07 wants to merge 8 commits into
ni:masterfrom
NI-velmurugan:users/diva/add-nidigital-burst-with-conditional-trigger-example
Draft

divakar-selvam07 wants to merge 8 commits into
ni:masterfrom
NI-velmurugan:users/diva/add-nidigital-burst-with-conditional-trigger-example

Conversation

@divakar-selvam07

@divakar-selvam07 divakar-selvam07 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor
  • This contribution adheres to CONTRIBUTING.md. Full build validation is pending.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds nidigital_burst_with_conditional_trigger.py, an example based on the LabVIEW "Burst with Conditional Trigger" VI.
  • Supports software and digital-edge conditional jump triggers, includes the original pattern configuration assets and Digital Pattern Editor project, and adds the example to the NI-Digital documentation.

List issues fixed by this Pull Request below, if any.

None.

What testing has been done?

  • Manually validated with a simulated instrument and an actual hardware instrument.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@codecov-commenter

codecov-commenter commented Oct 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.18%. Comparing base (5375937) to head (5eca951).

❌ Your project status has failed because the head coverage (75.18%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (5375937) and HEAD (5eca951). Click for more details.

HEAD has 47 uploads less than BASE
Flag BASE (5375937) HEAD (5eca951)
nitclkunittests 10 5
nifakeunittests 10 5
nimodinstunittests 10 5
nidcpowerunittests 10 5
niscopeunittests 10 5
nidigitalunittests 10 5
nirfsaunittests 10 5
codegenunittests 2 1
niscopesystemtests 1 0
nidigitalsystemtests 1 0
nidmmsystemtests 1 0
nirfsgsystemtests 1 0
nimodinstsystemtests 1 0
nisesystemtests 1 0
niswitchsystemtests 1 0
nidcpowersystemtests 1 0
nirfsasystemtests 1 0
nifgensystemtests 1 0
nitclksystemtests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2250       +/-   ##
===========================================
- Coverage   88.12%   75.18%   -12.94%     
===========================================
  Files          88       42       -46     
  Lines       22830     6633    -16197     
===========================================
- Hits        20118     4987    -15131     
+ Misses       2712     1646     -1066     
Flag Coverage Δ
codegenunittests 84.78% <ø> (ø)
nidcpowersystemtests ?
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests ?
nidigitalunittests 68.43% <ø> (ø)
nidmmsystemtests ?
nifakeunittests 86.08% <ø> (ø)
nifgensystemtests ?
nimodinstsystemtests ?
nimodinstunittests 94.20% <ø> (ø)
nirfsasystemtests ?
nirfsaunittests 63.37% <ø> (ø)
nirfsgsystemtests ?
niscopesystemtests ?
niscopeunittests 43.20% <ø> (ø)
nisesystemtests ?
niswitchsystemtests ?
nitclksystemtests ?
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants