Skip to content

fix(ci): adjust tests for a green CI - #9468

Merged
blizzz merged 1 commit into
mainfrom
fix/ci
Oct 26, 2026
Merged

blizzz merged 1 commit into
mainfrom
fix/ci

Conversation

@silverkszlo

Copy link
Copy Markdown
Collaborator

📝 Summary

Fixes two e2e failures caused by recent changes in the server and viewer:

  • Playwright print.spec.ts: the viewer modal now has a "Viewer settings" button (.viewer__settings). It was printed over the text at the bottom of page 1, which broke the snapshot comparison. The print styles now hide it, together with the modal header.
  • Cypress attachments.spec.js › Create a new whiteboard file: the test looked for .preview .widget-file.whiteboard. The whiteboard class came from the whiteboard app's own viewer component, which the files reference widget no longer uses (it now renders <nc-viewer-file class="widget-file widget-file--interactive">, server aa6adad57ef). The test now checks only what Text is responsible for: the created attachment is a .whiteboard file and a preview widget is inserted for it.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

Signed-off-by: silver <s.szmajduch@posteo.de>
Assisted-by: ClaudeCode:claude-opus-5.5
@silverkszlo silverkszlo added the AI assisted This PR contains AI-assisted commits label Oct 26, 2026
@blizzz
blizzz merged commit 74db30a into main Oct 26, 2026
65 checks passed
@blizzz
blizzz deleted the fix/ci branch October 26, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants