Repository navigation
Conversation
Signed-off-by: silver <s.szmajduch@posteo.de> Assisted-by: ClaudeCode:claude-opus-5.5
benjaminfrueh
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes two e2e failures caused by recent changes in the server and viewer:
print.spec.ts: the viewer modal now has a "Viewer settings" button (.viewer__settings). It was printed over the text at the bottom of page 1, which broke the snapshot comparison. The print styles now hide it, together with the modal header.attachments.spec.js› Create a new whiteboard file: the test looked for.preview .widget-file.whiteboard. Thewhiteboardclass came from the whiteboard app's own viewer component, which the files reference widget no longer uses (it now renders<nc-viewer-file class="widget-file widget-file--interactive">, server aa6adad57ef). The test now checks only what Text is responsible for: the created attachment is a.whiteboardfile and a preview widget is inserted for it.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)