Repository navigation
fix(call): do not ring for the push of the call the user is in - #6953
Open
ToteMeiSter wants to merge 1 commit into
Open
ToteMeiSter wants to merge 1 commit into
ToteMeiSter wants to merge 1 commit into
Conversation
A call push for the call the user already is in (for example after the other side rejoined) showed the full-screen incoming call and played the ringtone until the first answer of getPeersForCall removed it, and showed a missed call when that request failed. Drop such a push before anything is shown. Assisted-by: Claude Code:claude-sonnet-5-5 Signed-off-by: Krainov Gleb <krajnov.g@kontentplus.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A call push for the call the user already is in (for example after the other side rejoined) showed the full-screen incoming call and played the ringtone until the first answer of
getPeersForCallremoved it, and showed a missed call when that request failed.Changes:
ApplicationWideCurrentRoomHolder.isInCallOfRoom(roomToken, userId): the app is in a call, and the current room and account match.NotificationWorker: aTYPE_CALLpush for that room and account is dropped before anything is shown. A push for another room or another account rings as before.The account check is needed: a shared conversation has the same token for two accounts on the same server.
Fixes #6952
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.xTests:
ApplicationWideCurrentRoomHolderTest, 4 cases (own call; other conversation; other account; room open but not in the call). Without theinCallcheck the last case fails.🤖 AI (if applicable)
Trailers of the commit:
🤖 Generated with Claude Code