Repository navigation
feat(conversation-info): listable scope, @all mentions and SIP dial-in - #6946
Draft
AndyScherzinger wants to merge 1 commit into
Draft
AndyScherzinger wants to merge 1 commit into
AndyScherzinger wants to merge 1 commit into
Conversation
Moderators can now open a conversation to registered users (and guest app users), allow or restrict mentioning @ALL, and enable SIP dial-in, optionally without a PIN. When SIP dial-in is enabled, every participant sees the dial-in numbers, the meeting ID and their own PIN. The settings follow the screen's optimistic pattern: shown at once and taken back with a snackbar when the server refuses. They are gated on the listable-rooms, mention-permissions, sip-support and sip-support-nopin capabilities, and hidden in classified conversations. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Contributor
Contributor
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings three conversation settings to the conversation info screen that iOS and web already have:
listable-rooms,PUT room/{token}/listable).mention-permissions,PUT room/{token}/mention-permissions).canEnableSIP) and, withsip-support-nopin, allow dial-in without a PIN (PUT room/{token}/webinar/sip). When dial-in is enabled, every participant sees a "SIP dial-in" section with the dial-in info from the signaling settings (sipDialinInfo), the meeting ID and their own PIN, all selectable for copying.All three are hidden in classified conversations. The visibility and @ALL switches are shown to moderators of group and public conversations only. Changes are shown at once and taken back with a snackbar when the server refuses them, the same way as the other settings on the screen.
The room fields (
listable,mentionPermissions,sipEnabled,canEnableSIP,attendeePin) are read from the room response only; the conversation info screen loads the room from the network, so the database schema is unchanged.The guest app users switch is shown regardless of whether the Guests app is enabled, the same as on the create conversation screen; iOS hides it when the app is disabled.
🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)