Skip to content

fix(logging): always print HTTP logs to logcat in debug builds - #6945

Merged
AndyScherzinger merged 1 commit into
masterfrom
alwaysShowLogsInConsole
Oct 23, 2026
Merged

AndyScherzinger merged 1 commit into
masterfrom
alwaysShowLogsInConsole

Conversation

@mahibi

@mahibi mahibi commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

LoggingHttpInterceptor skipped HTTP logging unless advanced logging was enabled, so debug builds no longer showed HTTP traffic in the Android Studio console. Debug builds now always run the interceptor. The log level set in the app only decides what is written to the log file on the device, because Logger.d prints to logcat and only enqueues the entry for the file if the level allows it.

Release builds still log HTTP traffic only with advanced logging enabled, to avoid buffering and logging all request and response bodies.

Assisted-by: Claude Code:claude-opus-5-5

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

LoggingHttpInterceptor skipped HTTP logging unless advanced logging was
enabled, so debug builds no longer showed HTTP traffic in the Android
Studio console. Debug builds now always run the interceptor. The log
level set in the app only decides what is written to the log file on the
device, because Logger.d prints to logcat and only enqueues the entry
for the file if the level allows it.

Release builds still log HTTP traffic only with advanced logging
enabled, to avoid buffering and logging all request and response bodies.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added this to the 26.0.0 milestone Oct 23, 2026
@mahibi mahibi self-assigned this Oct 23, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Oct 23, 2026
@mahibi
mahibi requested a review from rapterjet2004 October 23, 2026 13:08
@github-actions

Copy link
Copy Markdown
Contributor

馃摫 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 705887c
Version 6945
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@github-actions

Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings138137
Errors1515

SpotBugs

CategoryBaseNew
Bad practice77
Correctness88
Dodgy code4040
Internationalization33
Malicious code vulnerability33
Performance88
Security1111
Total8080

@AndyScherzinger
AndyScherzinger merged commit dd7ca98 into master Oct 23, 2026
21 checks passed
@AndyScherzinger
AndyScherzinger deleted the alwaysShowLogsInConsole branch October 23, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants