Repository navigation
fix(chat): let taps on message actions work while the sheet animates - #6941
Merged
Merged
Conversation
Member
Author
|
Closing for now: the sheet's tap-swallowing during its animation is real in Material3 1.4.0, but on-device logs show taps landing after the sheet has settled, so this is not the cause of the reported issue. Investigating further with a debug build. |
Material3's ModalBottomSheet starts its drag on the touch down while the sheet is animating (startDragImmediately = isAnimationRunning). That drag consumes the down, so the tap on an action row is cancelled and nothing happens. Only after dragging or scrolling the sheet into a settled state did taps reach the actions again. Disable the sheet gestures while an animation runs, for both the message actions sheet and the one for temporary messages. Dragging works again as soon as the sheet has settled. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/message-actions-sheet-taps
branch
from
October 22, 2026 18:49
6a0a6ac to
ca23163
Compare
Contributor
📱 QA build
The QA build installs alongside a released Nextcloud app, so you can keep Downloading the file requires a GitHub account, so open this link on the |
Contributor
AndyScherzinger
marked this pull request as ready for review
October 23, 2026 09:22
AndyScherzinger
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taps on the actions of the message long-press bottom sheet were often ignored. Only after expanding, collapsing or scrolling the sheet did a tap trigger the action.
Material3's
ModalBottomSheet(1.4.0) putsdraggable(startDragImmediately = isAnimationRunning)on the sheet. While the sheet animates, the drag starts on the touch down and consumes it, so theclickableof the action row cancels the tap. Dragging or scrolling ends in a settle animation that leaves the sheet in a settled state, after which taps work again.The sheet gestures are now disabled while an animation runs (
sheetGesturesEnabled = !sheetState.isAnimationRunning), for the message actions sheet and for the one of temporary messages. Dragging the sheet works again once it has settled.🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x🤖 AI (if applicable)