Repository navigation
Conversation
Removed the innodb_buffer_pool_instances setting since its removed in MariaDB/MySQL. For quite some time now: https://mariadb.com/docs/release-notes/community-server/10.6/10.6.0#innodb-variables Signed-off-by: Melroy van den Berg <melroy@melroy.org>
Remove obsolete InnoDB and query cache options, replace legacy PHP MySQL settings with PDO socket guidance, and clarify engine-specific configuration. Assisted-by: Codex:GPT-6 Signed-off-by: Melroy van den Berg <melroy@melroy.org>
Assisted-by: Codex:GPT-6 Signed-off-by: Melroy van den Berg <melroy@melroy.org>
Assisted-by: Codex:GPT-6 Signed-off-by: Melroy van den Berg <melroy@melroy.org>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove obsolete database configuration options and update the PHP connection guidance.
innodb_buffer_pool_instancesas a commented-out option with an inline explanation: it is MySQL-only and was removed in MariaDB 10.6. MySQL 8.4 already defaults to one instance for this example's 128M buffer pool.innodb_large_prefixandinnodb_file_formatoptions.mysql.*extension settings with PDO_MYSQL socket guidance. Include a brief Ubuntu PHP 8.5-FPM example using a separate99-nextcloud.inioverride file, the reload command, and separate CLI configuration guidance. Only override an incorrect default socket path.The repeated obsolete options in
config_sample_php_parameters.rstneed a separate upstream fix in Nextcloud Server'sconfig.sample.php, since that documentation is generated.Once merged, please also merge the other PR (in the other repo): nextcloud/server#66121
AI assistance: OpenAI Codex (GPT-6) assisted with the review, documentation changes, local validation, and PR update.
☑️ Resolves
Fix #4758
🖼️ Screenshots
Before:
After (database configuration with the inline MySQL-only comment):
After (compatibility note, PDO socket override, and PHP-FPM/CLI configuration guidance):
✅ Checklist
codespellor similar and addressed any spelling issuesValidation:
make -C admin_manual htmlpassed with warnings treated as errors;sphinx-lint,codespell, andgit diff --checkpassed. The rendered page was reviewed in Chrome. Database startup compatibility was not tested.