Repository navigation
Qualify codegen against the merged Lambda follow-up fixes - #736
Merged
Merged
Conversation
Contributor
Author
|
Review of head The manifest change is two lines: Two notes, neither blocking:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source-build manifest still selects the AWS and native migration commits, so integration CI does not exercise the merged shared event mapper and schema-input isolation fixes. Pin AWS to
5913c7c25b01b6d384fd9c39014dc91d63dfc35e(networknt/light-aws-lambda#170, including #169) and native to5ba49d703b7b2c50bb7f2a99e359e287a541b150(networknt/light-lambda-native#190).Only these two manifest values change. The core/policy and remaining prerequisite pins are preserved. This controls the Jackson 3 source-build workflow; it does not alter Maven dependency versions or normal local-build resolution.
Validation: both selected commits are ancestors of fetched upstream master; the workflow's manifest key/hash/core checks pass, and the diff is whitespace-clean. Full source-build CI and its strict artifact audit must pass on this PR head before merge. No local Maven suite was rerun for the manifest-only change.
Current-head CI passed at
dfc6654aec2f78e547dab24fc2dd55b0c6884253: https://github.com/networknt/light-codegen/actions/runs/40515293950. Downloaded reports show 85 consumer tests, 6 skipped, zero failures/errors; generated Java and Kotlin projects compile successfully. The strict artifact audit has no failures or Jackson 2 dependencies, and all resolved source SHAs match the manifest, including both updated Lambda pins. Pre-commit also passes.