Repository navigation
fix: Node.js 24に型定義を揃える - #107
Merged
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
確認対象の依存関係、ロックファイル、Renovate設定に未解決の問題がなく、Node.js 24系への統一方針も一貫しているため。
No open issues 🎉
2 files not reviewed
infra/pnpm-lock.yaml: Generated filepnpm-lock.yaml: Generated file
What changed in this PR
Node.js 24の実行環境に合わせて、root・infra双方のNode.js型定義を24.19.2へ統一し、Renovateの更新範囲も24系に制限する変更です。
Changes:
- rootおよびinfraの
@types/nodeを24.19.2へ更新 - 両方のpnpmロックファイルを更新
- Renovateの
@types/node更新対象を24系に制限
| File | Description |
|---|---|
| pnpm-lock.yaml | rootの依存関係とNode.js型定義の解決結果を更新しています。 |
| package.json | rootの@types/nodeを24.19.2へ更新しています。 |
| infra/pnpm-lock.yaml | infraの依存関係とNode.js型定義の解決結果を更新しています。 |
| infra/package.json | infraの@types/nodeを24.19.2へ更新しています。 |
| .github/renovate.json5 | Renovateによる@types/nodeの更新対象を24系に制限しています。 |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
なし
変更内容
@types/nodeを25.9.9から24.19.2へ変更し、実行環境のNode.js 24とメジャーを揃える。@types/nodeの更新を24系に制限する。確認したこと
スクリーンショット
UI変更なし。
補足事項
Node.jsのメジャー更新時はRenovateの型定義更新範囲も変更する。Slack SDK経由の間接依存には25系が残るが、今回の型検査には読み込まれていない。
PR時のセルフチェック