Repository navigation
chore(deps): update dependency node to v26 - #103
renovate[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b10e17d57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version: "24.22.1" | ||
| node-version: "26.13.0" |
There was a problem hiding this comment.
Running the sole check workflow on Node 26 removes coverage for the production runtime, which remains Runtime.NODEJS_24_X in infra/lib/times-all-bot-stack.ts and is bundled with --target=node24. Code using Node 25/26-only APIs or behavior can therefore pass the unit tests and typecheck—especially now that @types/node also targets 26—but fail after deployment; keep this job on Node 24 or add Node 24 to a test matrix until the Lambda runtime is upgraded.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
🟡 Changes recommended
Two unresolved moderate findings remain because CI and @types/node target Node 26 while the deployed Lambda runtime is still NODEJS_24_X, so Node 24-specific failures could pass checks undetected.
2 open issues
1 file not reviewed
infra/package-lock.json: Generated file
What changed in this PR
Node.js の CI 実行環境と @types/node を、Renovate によりメジャーバージョン 24 系から 26 系へ更新する PR です。更新の意図は明確で、依存関係の管理も自動化されています。ただし、本番の Lambda ランタイムはまだ Node 24 系のため、Lambda のランタイムと CI の差をどう扱うかを決めてから進めるとより安全です。
Changes:
- GitHub Actions の 4 つの reusable workflow で
setup-nodeの Node.js バージョンを26.13.0に変更 - ルートと
infraのpackage.json/package-lock.jsonで@types/nodeを26.6.6に更新（推移的依存のundici-typesも更新）
| File | Description |
|---|---|
| package.json | @types/node を 26.6.6 に更新。Lambda ランタイム（Node 24）との差を型チェックに持ち込む点に注意が必要 |
| package-lock.json | 上記更新に伴うロックファイルの変更。undici-types も 8.9.0 へ更新 |
| infra/package.json | CDK 側の @types/node を 26.6.6 に更新。ルートと同じ検討が必要 |
| infra/package-lock.json | CDK 側のロックファイルの変更。依存解決結果を反映 |
| .github/workflows/_reusable_lambda_rie_test.yml | RIE テストの Node.js を 26.13.0 に変更。esbuild の target と Lambda イメージは Node 24 のまま |
| .github/workflows/_reusable_deploy.yml | デプロイジョブの Node.js を 26.13.0 に変更。Lambda ランタイムとの一致を確認が必要 |
| .github/workflows/_reusable_check.yml | チェックジョブの Node.js を 26.13.0 に変更 |
| .github/workflows/_reusable_cdk_synth.yml | CDK synth ジョブの Node.js を 26.13.0 に変更 |
Review effort: Lite
| - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version: "24.22.1" | ||
| node-version: "26.13.0" |
| "@tsconfig/strictest": "2.0.8", | ||
| "@types/aws-lambda": "8.10.163", | ||
| "@types/node": "25.9.6", | ||
| "@types/node": "26.6.6", |
1f66897 to
e657942
Compare
e657942 to
2d71a5e
Compare
2d71a5e to
7856120
Compare
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
24.22.2→26.13.025.9.6→26.6.6Release Notes
actions/node-versions (node)
v26.13.0: 26.13.0Compare Source
Node.js 26.13.0
v26.12.1: 26.12.1Compare Source
Node.js 26.12.1
v26.12.0: 26.12.0Compare Source
Node.js 26.12.0
v26.11.1: 26.11.1Compare Source
Node.js 26.11.1
v26.11.0: 26.11.0Compare Source
Node.js 26.11.0
v26.10.0: 26.10.0Compare Source
Node.js 26.10.0
v26.9.0: 26.9.0Compare Source
Node.js 26.9.0
v26.8.2: 26.8.2Compare Source
Node.js 26.8.2
v26.8.1: 26.8.1Compare Source
Node.js 26.8.1
v26.8.0: 26.8.0Compare Source
Node.js 26.8.0
v26.7.0: 26.7.0Compare Source
Node.js 26.7.0
v26.6.0: 26.6.0Compare Source
Node.js 26.6.0
v26.5.1: 26.5.1Compare Source
Node.js 26.5.1
v26.5.0: 26.5.0Compare Source
Node.js 26.5.0
v26.4.0: 26.4.0Compare Source
Node.js 26.4.0
v26.3.1: 26.3.1Compare Source
Node.js 26.3.1
v26.3.0: 26.3.0Compare Source
Node.js 26.3.0
v26.2.0: 26.2.0Compare Source
Node.js 26.2.0
v26.1.0: 26.1.0Compare Source
Node.js 26.1.0
v26.0.0: 26.0.0Compare Source
Node.js 26.0.0
Configuration
📅 Schedule: (in timezone Asia/Tokyo)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.