Repository navigation
Conversation
An amount of 10.5 was checksummed as 10.5, while the QR code writes 10.50. The helper now uses the same two decimal places, so its CRC matches the code.
naomijub
reviewed
Sep 26, 2026
Author
|
Cursor helped me spot it, and I checked the two-decimal CRC path before opening the PR. Happy to stand behind the change. No rush on the CI updates, and thanks for taking a look. |
Owner
|
Today I should update the CI, then you can update your branch with main and CI should work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encodewrites an amount with two decimal places.to_crc16_jsonchecksummedDisplayof the float instead, so10.5was checksummed as10.5while the QR code contains10.50. The CRC in the JSON did not match the code. The helper now uses the same two decimal places.123.45is unchanged.Test plan
cargo test --lib amount_with_one_decimalfails on master (the JSON CRC is5A08, not the CRC of the QR code) and passes with this change.enconde_brcodeandjson_crc16still pass.Made with Cursor