Repository navigation
Conversation
ybelMekk
force-pushed
the
fix/mcp-suppression-target
branch
from
November 11, 2026 11:41
2953cab to
a47e5f4
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The integration test expects component 0 in all three rows, but the fixture produces a MEDIUM finding for component 1, so the second expected purl must be corrected to avoid test failure.
1 open issue
1 file not reviewed
internal/graph/gengql/vulnerability.generated.go: Generated file
What changed in this PR
Exposes finding image names through the vulnerability GraphQL API so the CLI can display the image, package purl, and CVE before suppression. This is an additive, read-only change; suppression behavior and permissions remain unchanged.
Changes:
- Maps the upstream image name into
ImageVulnerabilityand exposes it in GraphQL. - Clarifies the existing
packagefield’s description. - Updates fake data, generated GraphQL code, and test coverage.
| File | Description |
|---|---|
| internal/vulnerability/transform.go | Maps the upstream image name. |
| internal/vulnerability/transform_test.go | Tests image name and package preservation. |
| internal/vulnerability/models.go | Adds the image name model field. |
| internal/vulnerability/fake/fakedata.go | Populates image names in fake findings. |
| internal/graph/schema/vulnerability.graphqls | Exposes imageName and clarifies package documentation. |
| internal/graph/gengql/vulnerability.generated.go | Adds generated field resolution. |
| internal/graph/gengql/root_.generated.go | Updates generated schema and field wiring. |
| integration_tests/vulnerabilities.lua | Adds image name and package assertions. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the read-only image-name addition.
No open issues 🎉
1 resolved since last review
1 file not reviewed
internal/graph/gengql/vulnerability.generated.go: Generated file
Review effort: Balanced
ybelMekk
marked this pull request as ready for review
November 11, 2026 12:01
ybelMekk
force-pushed
the
fix/mcp-suppression-target
branch
from
November 12, 2026 08:32
030ec3c to
493e0c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Expose ImageVulnerability.imageName from v13s so the confirmation in nais/cli#845 can display the image, versioned package purl and CVE before suppression. Reuse the existing package field.
Additive read-only change across tenants. Suppression mutations, permissions and actor attribution remain unchanged. Deploy before the CLI change.