Skip to content

feat(vulnerability): expose finding image names - #618

Open
ybelMekk wants to merge 2 commits into
mainfrom
fix/mcp-suppression-target
Open

ybelMekk wants to merge 2 commits into
mainfrom
fix/mcp-suppression-target

Conversation

@ybelMekk

@ybelMekk ybelMekk commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Expose ImageVulnerability.imageName from v13s so the confirmation in nais/cli#845 can display the image, versioned package purl and CVE before suppression. Reuse the existing package field.

Additive read-only change across tenants. Suppression mutations, permissions and actor attribution remain unchanged. Deploy before the CLI change.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The integration test expects component 0 in all three rows, but the fixture produces a MEDIUM finding for component 1, so the second expected purl must be corrected to avoid test failure.

1 open issue
1 file not reviewed
  • internal/graph/gengql/vulnerability.generated.go: Generated file
What changed in this PR

Exposes finding image names through the vulnerability GraphQL API so the CLI can display the image, package purl, and CVE before suppression. This is an additive, read-only change; suppression behavior and permissions remain unchanged.

Changes:

  • Maps the upstream image name into ImageVulnerability and exposes it in GraphQL.
  • Clarifies the existing package field’s description.
  • Updates fake data, generated GraphQL code, and test coverage.
File Description
internal/​vulnerability/​transform.go Maps the upstream image name.
internal/​vulnerability/​transform_test.go Tests image name and package preservation.
internal/​vulnerability/​models.go Adds the image name model field.
internal/​vulnerability/​fake/​fakedata.go Populates image names in fake findings.
internal/​graph/​schema/​vulnerability.graphqls Exposes imageName and clarifies package documentation.
internal/​graph/​gengql/​vulnerability.generated.go Adds generated field resolution.
internal/​graph/​gengql/​root_.generated.go Updates generated schema and field wiring.
integration_tests/​vulnerabilities.lua Adds image name and package assertions.

Review effort: Balanced

Comment thread integration_tests/vulnerabilities.lua Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the read-only image-name addition.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • internal/graph/gengql/vulnerability.generated.go: Generated file

Review effort: Balanced

@ybelMekk
ybelMekk marked this pull request as ready for review November 11, 2026 12:01
@ybelMekk
ybelMekk requested a review from a team as a code owner November 11, 2026 12:01
@ybelMekk
ybelMekk force-pushed the fix/mcp-suppression-target branch from 030ec3c to 493e0c6 Compare November 12, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants