Repository navigation
Spelling test: don't fail on words found only in NEWS.md - #216
Merged
Merged
Conversation
NEWS.md routinely names new technical terms, which made the spelling test fail until they were added to inst/WORDLIST. tests/spelling.R now runs spelling::spell_check_package() itself (same source-directory lookup and NOT_CRAN skip as spell_check_test()), prints NEWS-only words, and stops only for words found elsewhere. As in agent-issues/TreeSearch#192.
Performance benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 60 60
Lines 6065 6065
=======================================
Hits 5918 5918
Misses 147 147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEWS.md routinely names new technical terms, which made the spelling test fail until they were added to
inst/WORDLIST(as happened with POPCNT/CPUID on ms609/TreeTools#288).tests/spelling.Rnow callsspelling::spell_check_package()directly. It uses the same source-directory lookup and the same skip on CRAN (NOT_CRAN) asspell_check_test(). Words found only in NEWS.md are printed and do not fail the test; words found anywhere else still stop it. Add the NEWS-only words to the WORDLIST at release.Same change as agent-issues/TreeSearch#192. Checked with local R 4.6.1: the script runs, and classifies words by where they occur.