Repository navigation
Bound Rogue SPR candidates with parent dual prices - #215
Merged
Merged
Conversation
Solve the parent pair's assignment once per spr_rogue_scores() call and price each candidate's splits with the parent column duals. The bound sum(v) + sum_i min_j(c_ij - v_j) is valid for any prices, so it is exact in int64; candidates it rejects skip the LAP, and the rest warm-start JV from the same prices (lap_warm.cpp). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
Benchmarks, workloads, offline LAP-bound analyzer and patches behind dev/rogue_mci_bound_findings.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
Skip the parent LAP when the row bound rejects every candidate, as on near-identical pairs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
ms609
marked this pull request as ready for review
October 14, 2026 10:28
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
spr_rogue_scores() requires binary trees (reduce_trees() overflows on a star, flagged by ASan); the empty-split guard it covered is unreachable from SPRDist() and is marked #nocov. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7
This comment has been minimized.
This comment has been minimized.
Performance benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 97.44% 97.57% +0.12%
==========================================
Files 59 60 +1
Lines 5762 6065 +303
==========================================
+ Hits 5615 5918 +303
Misses 147 147 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: for almost every candidate leaf,
SPRDist(method = "Rogue")solves a full LAP, and 89% of those LAPs end below the running minimum. The LAP accounts for 52% of runtime at 80 leaves and 66% at 150.After: the parent pair's LAP is solved once, lazily, on the first candidate that passes the row bound. Each candidate's splits are then priced with the parent's column duals.
LB(v) = Σ_j v_j + Σ_i min_j (c_ij − v_j)is at most the optimal assignment cost. The bound is therefore exact in int64, and the prices affect only speed.src/lap_warm.cpp, kept in its own translation unit so thatlap()'s codegen is untouched).Wall-clock (prototype, eager prices; minimum over interleaved runs):
Verification:
SPRDist()output was identical on 345 pair runs.SPRDist()matches the R path on 40 random pairs of 8–60 leaves.#nocov.The research write-up and scripts are in
dev/rogue_mci_bound_findings.mdanddev/rogue_bound/, which.Rbuildignoreexcludes from the package build.🤖 Generated with Claude Code
https://claude.ai/code/session_014CDmnvPhnKFWMrQgqPKVY7